Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 27 Oct 2020 09:03:51 +0000
From:   Marc Zyngier <maz@kernel.org>
To:     balbi@kernel.org
Cc:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] irqchip: bcm2836: fix section mismatch warning
In-Reply-To: <20201027085157.1964906-3-balbi@kernel.org>
References: <20201027085157.1964906-1-balbi@kernel.org>
 <20201027085157.1964906-3-balbi@kernel.org>
User-Agent: Roundcube Webmail/1.4.9
Message-ID: <49f17502445e5ae5b35df15577957ae6@kernel.org>
Precedence: bulk

On 2020-10-27 08:51, balbi@kernel.org wrote:
> From: Felipe Balbi <balbi@kernel.org>
> 
> Fix the following warning:
> 
> WARNING: modpost: vmlinux.o(.text.unlikely+0x17b2c): Section mismatch
> in reference from the function bcm2836_arm_irqchip_smp_init() to the
> function .init.text:set_smp_ipi_range()
> The function bcm2836_arm_irqchip_smp_init() references
> the function __init set_smp_ipi_range().
> This is often because bcm2836_arm_irqchip_smp_init lacks a __init
> annotation or the annotation of set_smp_ipi_range is wrong.
> 
> Signed-off-by: Felipe Balbi <balbi@kernel.org>
> ---
>  drivers/irqchip/irq-bcm2836.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-bcm2836.c 
> b/drivers/irqchip/irq-bcm2836.c
> index 97838eb705f9..cbc7c740e4dc 100644
> --- a/drivers/irqchip/irq-bcm2836.c
> +++ b/drivers/irqchip/irq-bcm2836.c
> @@ -244,7 +244,7 @@ static int bcm2836_cpu_dying(unsigned int cpu)
> 
>  #define BITS_PER_MBOX	32
> 
> -static void bcm2836_arm_irqchip_smp_init(void)
> +static void __init bcm2836_arm_irqchip_smp_init(void)
>  {
>  	struct irq_fwspec ipi_fwspec = {
>  		.fwnode		= intc.domain->fwnode,

I already have a fix for this one[1], which should be in -next.

Thanks,

         M.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/irqchip-next&id=57733e009f0c7e0526e10a18be12f56996c5460e
-- 
Jazz is not dead. It just smells funny...