Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Oct 2020 11:38:27 +0100
From:   Krzysztof Kozlowski <krzk@kernel.org>
To:     Marek Szyprowski <m.szyprowski@samsung.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Sylwester Nawrocki <snawrocki@kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH 04/12] ARM: dts: exynos: adjust node names to DT spec in
 Exynos4412 boards
Message-ID: <20201027103827.GB20429@kozik-lap>
References: <20201026181528.163143-1-krzk@kernel.org>
 <CGME20201026181555eucas1p265c52e647f7cd28d410135ccbd236b70@eucas1p2.samsung.com>
 <20201026181528.163143-5-krzk@kernel.org>
 <7832e031-81b0-c77e-57fa-cf122cd989d4@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <7832e031-81b0-c77e-57fa-cf122cd989d4@samsung.com>
Precedence: bulk

On Mon, Oct 26, 2020 at 10:02:10PM +0100, Marek Szyprowski wrote:
> 
> On 26.10.2020 19:15, Krzysztof Kozlowski wrote:
> > The Devicetree specification expects device node names to have a generic
> > name, representing the class of a device.  Also the convention for node
> > names is to use hyphens, not underscores.
> >
> > No functional changes.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >   arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi   |  8 ++++----
> >   arch/arm/boot/dts/exynos4412-itop-elite.dts   |  2 +-
> >   .../boot/dts/exynos4412-itop-scp-core.dtsi    |  2 +-
> >   arch/arm/boot/dts/exynos4412-midas.dtsi       | 12 +++++------
> >   arch/arm/boot/dts/exynos4412-n710x.dts        |  2 +-
> >   .../boot/dts/exynos4412-odroid-common.dtsi    |  8 ++++----
> >   arch/arm/boot/dts/exynos4412-odroidx.dts      |  4 ++--
> >   arch/arm/boot/dts/exynos4412-origen.dts       | 14 ++++++-------
> >   arch/arm/boot/dts/exynos4412-smdk4412.dts     | 20 +++++++++----------
> >   9 files changed, 36 insertions(+), 36 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > index 89ed81fb348d..db91678f5648 100644
> > --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > @@ -15,7 +15,7 @@ aliases {
> >   		i2c10 = &i2c_cm36651;
> >   	};
> >   
> > -	aat1290 {
> > +	led-controller {
> >   		compatible = "skyworks,aat1290";
> >   		flen-gpios = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> >   		enset-gpios = <&gpj1 2 GPIO_ACTIVE_HIGH>;
> > @@ -60,7 +60,7 @@ i2c_ak8975: i2c-gpio-0 {
> >   		#size-cells = <0>;
> >   		status = "okay";
> >   
> > -		ak8975@c {
> > +		magnetometer@c {
> >   			compatible = "asahi-kasei,ak8975";
> >   			reg = <0x0c>;
> >   			gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>;
> > @@ -75,7 +75,7 @@ i2c_cm36651: i2c-gpio-2 {
> >   		#address-cells = <1>;
> >   		#size-cells = <0>;
> >   
> > -		cm36651@18 {
> > +		sensor@18 {
> light-sensor?

Ack, to this and all following. Thanks.

Best regards,
Krzysztof