Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965277AbWHOHkK (ORCPT ); Tue, 15 Aug 2006 03:40:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965262AbWHOHkK (ORCPT ); Tue, 15 Aug 2006 03:40:10 -0400 Received: from mtagate1.uk.ibm.com ([195.212.29.134]:11700 "EHLO mtagate1.uk.ibm.com") by vger.kernel.org with ESMTP id S965221AbWHOHkI (ORCPT ); Tue, 15 Aug 2006 03:40:08 -0400 Date: Tue, 15 Aug 2006 09:39:59 +0200 From: Heiko Carstens To: Jan-Bernd Themann Cc: netdev , linux-ppc , linux-kernel , Marcus Eder , Christoph Raisch , Thomas Klein , Jan-Bernd Themann , Thomas Klein Subject: Re: [PATCH 1/7] ehea: interface to network stack Message-ID: <20060815073959.GB6922@osiris.boeblingen.de.ibm.com> References: <44E0A4CC.4090705@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44E0A4CC.4090705@de.ibm.com> User-Agent: mutt-ng/devel-r804 (Linux) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 30 > +int __init ehea_module_init(void) > +{ > + int ret = -EINVAL; > + > + EDEB_EN(7, ""); > + > + printk(KERN_INFO "IBM eHEA Ethernet Device Driver (Release %s)\n", > + DRV_VERSION); > + > + > + ret = ibmebus_register_driver(&ehea_driver); > + if (ret) { > + EDEB_ERR(4, "Failed registering eHEA device driver on ebus"); > + return -EINVAL; > + } > + > + EDEB_EX(7, ""); > + return 0; > +} Function should be static and could be shortened to the single line return ibmebus_register_driver(&ehea_driver); , I guess :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/