Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Oct 2020 14:01:11 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Nicolin Chen <nicoleotsuka@gmail.com>
Cc:     krzk@kernel.org, robh+dt@kernel.org, jonathanh@nvidia.com,
        linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] memory: tegra: Complete tegra210_swgroups
Message-ID: <20201027130111.GB1822510@ulmo>
References: <20201008003746.25659-1-nicoleotsuka@gmail.com>
 <20201008003746.25659-6-nicoleotsuka@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="St7VIuEGZ6dlpu13"
Content-Disposition: inline
In-Reply-To: <20201008003746.25659-6-nicoleotsuka@gmail.com>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--St7VIuEGZ6dlpu13
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 07, 2020 at 05:37:46PM -0700, Nicolin Chen wrote:
> According to Tegra X1 TRM, there are missing swgroups in the
> tegra210_swgroups list. So this patch adds them to the list.
>=20
> Note that the TEGRA_SWGROUP_GPU (in list) should be actually
> TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM)
> is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So
> this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps
> TEGRA_SWGROUP_GPU (in list) as it is.
>=20
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
>  drivers/memory/tegra/tegra210.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>=20
> diff --git a/drivers/memory/tegra/tegra210.c b/drivers/memory/tegra/tegra=
210.c
> index b400802c9f14..b3bbc5a05ba1 100644
> --- a/drivers/memory/tegra/tegra210.c
> +++ b/drivers/memory/tegra/tegra210.c
> @@ -1028,6 +1028,8 @@ static const struct tegra_smmu_swgroup tegra210_swg=
roups[] =3D {
>  	{ .name =3D "hda",       .swgroup =3D TEGRA_SWGROUP_HDA,       .reg =3D=
 0x254 },
>  	{ .name =3D "isp2",      .swgroup =3D TEGRA_SWGROUP_ISP2,      .reg =3D=
 0x258 },
>  	{ .name =3D "nvenc",     .swgroup =3D TEGRA_SWGROUP_NVENC,     .reg =3D=
 0x264 },
> +	{ .name =3D "nv",        .swgroup =3D TEGRA_SWGROUP_NV,        .reg =3D=
 0x268 },
> +	{ .name =3D "nv2",       .swgroup =3D TEGRA_SWGROUP_NV2,       .reg =3D=
 0x26c },

Oddly enough I can see these in the TRM, but they are not in the
internal reference manuals that are supposed to be the canonical
reference for the TRM. Perhaps the TRM is out of date?

Thierry

--St7VIuEGZ6dlpu13
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+YGhcACgkQ3SOs138+
s6Gs7w/+NnyjKzJTeMqiNTu+JrNR0LUAPyE84D55SoweRFJRqj5qd4QYRmPNxACG
8ARl63jbR9zR94HplRkUpxvxYd2z+Z9udpg5ADm2TVoj6rSxBksxeNa9XAYZ/S+F
A5/EUTWbkhqppMyH3TGQn5/l/Gyx6h79dtmmz0BK5dB8KhfQypX6L5TCzuNscS80
JRJbrtFkiWdR3Z9SnpnPmJD6+1mnJIHnK/3wbVp7TOOUp7VSo/fABJazXr+VXHzB
8wGxk1h8o220pKAc2WNBmlHdnJUs4FukjRQZ6Skalt1ZRXpe6wIzjG9L0+n6jESP
hxaPIQ9JdPghTGkusF17CIECe6Ex0H1igvfxK59IXzrTI2tjrkWjIofVyLQ9v0ZH
45l0/plCrvxoNUtwXRKAxQP+YPQCbQ7MRetuQ2E3WJQBnmZ03M3E9c93ArABtilH
YMF91N11uOtqLS3wf0+A28/z7saIK8AxYVD/33ep742I4MKtkqj0FS06N33I8y26
rjPpkdIWhDW0WjVAYuHYX1RgT1VTVPAQdwanpV1GJuX0qk0CM+D7CONUBT+282CA
wOKjHKi3XcCyLZYw6igetXNJo3JiAjtaoSCDAQVTgyR/9FN+1kwRDBukNLRHxNcx
IA5jt6ru/tVg6Dne2DQ8sYp8L+2bBNr2vOh93iS7mAc2TTNXxAs=
=ypbK
-----END PGP SIGNATURE-----

--St7VIuEGZ6dlpu13--