Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Oct 2020 14:03:01 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Tang Bin <tangbin@cmss.chinamobile.com>
Cc:     stern@rowland.harvard.edu, gregkh@linuxfoundation.org,
        jonathanh@nvidia.com, linux-usb@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: host: ehci-tegra: Fix error handling in
 tegra_ehci_probe()
Message-ID: <20201027130301.GC1822510@ulmo>
References: <20201026090657.49988-1-tangbin@cmss.chinamobile.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="qtZFehHsKgwS5rPz"
Content-Disposition: inline
In-Reply-To: <20201026090657.49988-1-tangbin@cmss.chinamobile.com>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--qtZFehHsKgwS5rPz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 26, 2020 at 05:06:57PM +0800, Tang Bin wrote:
> If the function platform_get_irq() failed, the negative value
> returned will not be detected here. So fix error handling in
> tegra_ehci_probe().
>=20
> Fixes: 79ad3b5add4a ("usb: host: Add EHCI driver for NVIDIA Tegra SoCs")
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
>  drivers/usb/host/ehci-tegra.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index 75a075daf..7b0efaf15 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -479,9 +479,9 @@ static int tegra_ehci_probe(struct platform_device *p=
dev)
>  	u_phy->otg->host =3D hcd_to_bus(hcd);
> =20
>  	irq =3D platform_get_irq(pdev, 0);
> -	if (!irq) {
> -		err =3D -ENODEV;
> -		goto cleanup_phy;
> +	if (irq < 0) {
> +		err =3D irq;
> +		goto cleanup_phy;
>  	}
> =20
>  	otg_set_host(u_phy->otg, &hcd->self);

Acked-by: Thierry Reding <treding@nvidia.com>

--qtZFehHsKgwS5rPz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+YGoUACgkQ3SOs138+
s6GZUA/+JuSpXjUsoZE9QowE0w/gzP2RDl6eBSJcKvL9KJSOoydP5AHCfKuVk2UO
f+dCqptwPH32vcASHayD0yaNU9rFJtK7H+7fR8Q8RH9kJ3ZPhro3GjatJZymZtj4
2zfmR+y+kjoOzDFM2GxLwZil/h4+ACcejpV4oQ1iRYC7VHBbPo3TBOip/Mutb0vr
1Quu0rehKgZS1hGQdUfSBKf2yr3Xb+OPnYAWzoVW/+a8nh7dyEu3Sp3CkPdHkKRT
MT9sw8aWaVdRzfjvQhxGJqo2iqV9rQCoDqDrV3erGlxsAc2anmG9K34o6btQejYi
Ubi+mvCM7dI4dcSaqgEA/OJSNDUAC6aKg1j0dc59JkKj9iALdMvtxZPKonzZdRZM
YJsLKhXcE+NZ0MxmJsV/NeBmbE7RKmTDuHWASQYZUl5rtmIulc3JyYngH7eQwNUf
D6peaHPxPOOnQ/IaxL0NP1IauaQMQ1ll36ZyeYUnRzCeMrHsqY0ENkOr2X51Tpy3
y2OgCArLGumjz2uKESiqmn4Iq83eyIacyXnAzTWC1PB3QQAbPKXFqkORPAef+na5
1rcfNss+dartFdWfGqUl6TxP0IBnryn4l3Td8Oj15/98RaDafTG8hCAIxq2y/u9u
mNfMKomGdJpkklLlPGQAp7jTMBuB5l8KsA+c06iR2VPCfgGN3w4=
=xKhy
-----END PGP SIGNATURE-----

--qtZFehHsKgwS5rPz--