Date: Tue, 15 Aug 2006 02:15:03 -0700 (PDT)
Message-Id: <20060815.021503.71555009.davem@davemloft.net>
To: jesper.juhl@gmail.com
Cc: linux-kernel@vger.kernel.org, kkeil@suse.de, kai.germaschewski@gmx.de,
       isdn4linux@listserv.isdn4linux.de
Subject: Re: [PATCH] ISDN: fix double free bug in isdn_net
From: David Miller <davem@davemloft.net>
In-Reply-To: <9a8748490608150208v4e8b7dccl6dd501a6f2cda4fc@mail.gmail.com>
References: <200608122248.22639.jesper.juhl@gmail.com>
	<20060815.020004.76775981.davem@davemloft.net>
	<9a8748490608150208v4e8b7dccl6dd501a6f2cda4fc@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 743
Lines: 16

From: "Jesper Juhl" <jesper.juhl@gmail.com>
Date: Tue, 15 Aug 2006 11:08:35 +0200

> Hmm, perhaps I made a mistake and missed a path. Maybe it would be
> better to fix if by making isdn_writebuf_skb_stub() always set the skb
> to NULL when it does free it. That would add a few more assignments
> but should ensure the right result always.
> What do you say?

Do we know if the ->writebuf_skb() method ever frees the skb?  If it
never does, then yes your suggestion would be one way to handle this.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/