Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965362AbWHOKWS (ORCPT ); Tue, 15 Aug 2006 06:22:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965364AbWHOKWR (ORCPT ); Tue, 15 Aug 2006 06:22:17 -0400 Received: from filfla-vlan276.msk.corbina.net ([213.234.233.49]:28855 "EHLO screens.ru") by vger.kernel.org with ESMTP id S965362AbWHOKWR (ORCPT ); Tue, 15 Aug 2006 06:22:17 -0400 Date: Tue, 15 Aug 2006 18:46:06 +0400 From: Oleg Nesterov To: Esben Nielsen Cc: Steven Rostedt , Andrew Morton , Ingo Molnar , Thomas Gleixner , Esben Nielsen , LKML Subject: Re: [PATCH] cleanup and remove some extra spinlocks from rtmutex Message-ID: <20060815144606.GA239@oleg> References: <1154439588.25445.31.camel@localhost.localdomain> <20060813190326.GA2276@oleg> <20060815110353.GA111@oleg> <20060815142605.GA232@oleg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 23 On 08/15, Esben Nielsen wrote: > > On Tue, 15 Aug 2006, Oleg Nesterov wrote: > > > >Sure, this needs a comment. > > It is even better if you can read the code without a comment. Good code > doesn't need comments. Yes. But from my point of view, the current code needs a comment to explain why do we take ->pi_lock, this is hard to understand at least to me. It is even better if we don't take ->pi_lock for ->wait_list manipulation. Imho. Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/