Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp216422pxx; Wed, 28 Oct 2020 03:06:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJys3m0et+HEyMBcu7GkFzWoApcbOJluBYeRHVYvzuUND4cNt7begN+udb+l/OFUH0cdki8u X-Received: by 2002:a05:6402:142a:: with SMTP id c10mr7034867edx.261.1603879582719; Wed, 28 Oct 2020 03:06:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603879582; cv=none; d=google.com; s=arc-20160816; b=cnKOvN1lpf42nQCpjqGz8H1G7ehMHevUuXftGqxapS5yVVkNctRda7geZWvsnB5+r0 7Lw8B/xTq+HX1RHLh/k/akjKrv8nX5yyOkRqjyqTdB90ERRmYqNUUdpqqbxqgkahNv0V aB9PipUKc9T4QSiqu9YdmGz/wB5HGlzdDx2otK8LfRdKyy4hYshVp+kgKjCtzH9GBdNZ 9FB/xyYJQCE0HhkQaW277em76Jx3A534ueybgVoNGlVkxcjFi/mdQPlc26xzsZslOgRM ydU6tJu43wwPlDfrrnrKNnqw3HypMvovrIfHAas1i2n8ASLLvi0D8OdfeyXQg/A5l1WA sr3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=uHhNFe7AIfOwHp9/PjaxBUPQx3OGYPfVPWLiUVFXMK4=; b=N2l0fGoX33xdgG0MBRCA+5yAjs2FjH0F5rctNa6jeKFnhAPexLX05/23fmIXrz66C0 bPoNVbCQN2xvED6haf5Xlg8pFaES/RBMaVUBMSWuAul4+GylHsk7Dd/QiNVBGxUyOAa0 h3bJMsNwwEB88iHmODi4G8ogioz25k31lROsqMgWFEFrADQ9i4UYtSGKXnk2hFKEFxLG 5FxXHl5r0kiF5dpqvRu04Ao6iqxxe4sVHyJ4VXtr/H75t3v2QI8IetN7ytVo78j2Walc BzmoCN/Tb8dbalDo7W2/vYOAGfhWQ6nc4ckKOkIXKwDxMgoF2V+9rROGXoJ/E3O/15KA BBlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zLDSoaKu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jr1si3058858ejb.164.2020.10.28.03.06.00; Wed, 28 Oct 2020 03:06:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zLDSoaKu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2902474AbgJ0Odu (ORCPT + 99 others); Tue, 27 Oct 2020 10:33:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:58336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2897378AbgJ0Obf (ORCPT ); Tue, 27 Oct 2020 10:31:35 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0DAD2206DC; Tue, 27 Oct 2020 14:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603809094; bh=5PeYcanFkuDfqhc8YhOoYXsGarkvnJEjS9L5CZOjriU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zLDSoaKuCEQfUjCGpfqNFUoBSS40gEl5rL1PuShrmoIpZP+A10JGw4MNA1L1C/Mx4 RL1Dmydu/s+PRzZmHDSxl/nDXN9MdWEC0ZitYRZbGXMCAGxjd+iAfN5lLDPruU0ouC 5fEgOdsqPdZ+ozSxWjedxQx037nbmlmAompu7eBU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paul Kocialkowski , Jacopo Mondi , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.4 073/408] media: ov5640: Correct Bit Div register in clock tree diagram Date: Tue, 27 Oct 2020 14:50:11 +0100 Message-Id: <20201027135458.448099198@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135455.027547757@linuxfoundation.org> References: <20201027135455.027547757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paul Kocialkowski [ Upstream commit 4c85f628f6639e3e3e0a7788416154f28dfcae4f ] Although the code is correct and doing the right thing, the clock diagram showed the wrong register for the bit divider, which had me doubting the understanding of the tree. Fix this to avoid doubts in the future. Signed-off-by: Paul Kocialkowski Fixes: aa2882481cada ("media: ov5640: Adjust the clock based on the expected rate") Acked-by: Jacopo Mondi Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/ov5640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 266e947572c1e..b21ddbd514465 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -740,7 +740,7 @@ static int ov5640_mod_reg(struct ov5640_dev *sensor, u16 reg, * +->| PLL Root Div | - reg 0x3037, bit 4 * +-+------------+ * | +---------+ - * +->| Bit Div | - reg 0x3035, bits 0-3 + * +->| Bit Div | - reg 0x3034, bits 0-3 * +-+-------+ * | +-------------+ * +->| SCLK Div | - reg 0x3108, bits 0-1 -- 2.25.1