Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp220788pxx; Wed, 28 Oct 2020 03:13:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOrd+ofBZQSvudcewwWaCOenkjhzp4iq/OlT0aj2kbR2wr2n9ByfANgMjvH0k54UJq8BR5 X-Received: by 2002:a05:6402:1447:: with SMTP id d7mr6949672edx.158.1603880027886; Wed, 28 Oct 2020 03:13:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603880027; cv=none; d=google.com; s=arc-20160816; b=eRT+Toda6dYcvMh46DewfI9QVtHZ4ykZVfrL3p6IsIHxiyimvG4byn4rkZ/6WNs5N2 P7mJ5AiSZriNIe/4TSiY5qAGkTEGytJpyrMMS1tXzCqylXJNp1Ijl4LhirKhEh88VCZS BHjjBzcAasMOt7Ds8p4FOoNX53h9GM+0Aok3TQW/82i+KbvuMU8HHn/cy5zdp6J9SC19 ewvYGyL6knEcMF/AnMb8+2HTzDRuFmdDyVRO/cZ5HMA++MO+h2eQHDY2RiMO0ZzpUcOh 9txS08k5TT6oXv4JJp19Cx/YOE1xlhOf6fkQBZEkvPuDb2DI1Oe3dgFHU2VljPHBd78Y ejaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=P04zZtBpXkdo90qjDEE6aSRj4CUf7OzjNAtfJ8mDn9w=; b=gw2kBN68jYvvAGa4dlVHCFWxkeoEl/QL57rbdk3dSeocAxusQMWkgK8BlOnBP7aKCm cT3YnXy6QbffDEtEHkwSM+cyZyKVeDlhhmYXVONkjtpA2WnzVdyVsXzhWzed5PIHOXYm tmH8NiikuAbYV7KPfrCEZR7rWxnuowqzpM1OG/2Am02+MocNEzJxSV6ycZ1umjh+soVC 8oyd/WYog8+GbFzDtF+JoTv6/BsbGgWRJ2Yv+DRME0izZX+6cPgsGM3eUCarS+3WEtGW cq3+HrftJgBhm7BUGUmpfra5LXvtpqnr9SWAqpB3nHkANhXC81Opdwl4Jic2O73B/2zU G4bA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VITEkqx5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z8si2802677eju.267.2020.10.28.03.13.25; Wed, 28 Oct 2020 03:13:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VITEkqx5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760789AbgJ0Og2 (ORCPT + 99 others); Tue, 27 Oct 2020 10:36:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:34712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760685AbgJ0Ofz (ORCPT ); Tue, 27 Oct 2020 10:35:55 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2401B22202; Tue, 27 Oct 2020 14:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603809354; bh=qyiZo9aIKs9oxo6H/sDcKtcMLDUgMZ3Z+/f6vnPjMwY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VITEkqx5vOa46DDEgYuPgWgQ6xxvaOKNUO7HmyQWz7MjsQocejhB4A8EPaGxbEsjH GjQiaabSk5H2eQEFIScnrgeTMufnuSTbJ1KhHe3EFwLWbiFxUAAlaJAjebZWI5M8XP YCyzxdXBQhO4wF5XHVdFYa/lqlC5AXnVBon90xSg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Sasha Levin Subject: [PATCH 5.4 166/408] slimbus: core: do not enter to clock pause mode in core Date: Tue, 27 Oct 2020 14:51:44 +0100 Message-Id: <20201027135502.795711516@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135455.027547757@linuxfoundation.org> References: <20201027135455.027547757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Srinivas Kandagatla [ Upstream commit df2c471c4ae07e18a0396db670dca2ef867c5153 ] Let the controller logic decide when to enter into clock pause mode! Entering in to pause mode during unregistration does not really make sense as the controller is totally going down at that point in time. Fixes: 4b14e62ad3c9e ("slimbus: Add support for 'clock-pause' feature") Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20200925095520.27316-3-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/slimbus/core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 42a233fc5dc6c..130c798921b5d 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -302,8 +302,6 @@ int slim_unregister_controller(struct slim_controller *ctrl) { /* Remove all clients */ device_for_each_child(ctrl->dev, NULL, slim_ctrl_remove_device); - /* Enter Clock Pause */ - slim_ctrl_clk_pause(ctrl, false, 0); ida_simple_remove(&ctrl_ida, ctrl->id); return 0; -- 2.25.1