Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp260200pxx; Wed, 28 Oct 2020 04:21:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1/SZBseIOhsYxegI5pjbHG4RmX7LswRD+TxvFdqfGKp5NwHle+0/iou3AZLjfvC+bVBUN X-Received: by 2002:a50:8b65:: with SMTP id l92mr7350279edl.132.1603884105690; Wed, 28 Oct 2020 04:21:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603884105; cv=none; d=google.com; s=arc-20160816; b=tz9y3xrd7OGb/nuydnK0U7sZXO2WEDTBlFfm+6uczMgeoHPWGEnO7mylMlj4nXMa4Q 1IV+WDdV1ZGnrT+6ttEmC5UZbDb6Fbi58wA6hgigjp4rBlW2NDMBIlJYLwxFrym+YhRB boV1CKVlV18tqEnCDN8mSPUEe/T/H9fYzrDScCGdt7izLKYadGQb8uLVJxNjL3BAQ3KQ 2Bk9xZv4w08xZ6r5waTfm+1EFWy4FgFBV78TBdEwU6DA57agYk5lIgv/rk999dkwEx76 ekaozFEvzrvAUmaXVu34koCYeVuQMBRCWYTySjjXXIVHApaIfCFswPgVivtnKTbBz5wI SzgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Jf1/sT5vRA4V15+ubvunPvB2TjJlTaWbvWf+iopnPAs=; b=dvf4PKOYZh1k1MOLFWdGjSvsWnqkUKnkOxuS1L9/PvJ3gnvK5FmLM1mzgh6UozNFWS sGrFaBwHEbxLAXPZ819IH7UyDijYjQc5kQmrfX1n+AJ7O67lx7WSGYsXgoHq4ka9DYft I77JxItLrPnuHD52Whzfef0RwXTIzUXOtExitg5rWXqvqLvvs+z5Npy+a93eq2pEyTu+ IJ1U8PKZqGp0raZS6M5blvduoj6L7XcgMNvlQQB7EwsGx8BPQuHvfANQnwVwUPO7LPoD tvHigKRbfUp95pIiz6g7YKp3hnNF0bO/ADvfnpZ53xyPbOUoVhALeM3VdGPQCjBbh9KA koiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=h0oBrBQO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gf17si2900638ejb.226.2020.10.28.04.21.23; Wed, 28 Oct 2020 04:21:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=h0oBrBQO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1789665AbgJ0PC0 (ORCPT + 99 others); Tue, 27 Oct 2020 11:02:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:60874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1784585AbgJ0O7Q (ORCPT ); Tue, 27 Oct 2020 10:59:16 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 615D520714; Tue, 27 Oct 2020 14:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603810756; bh=CZGrA1IfK0TadZ9bTfmryHnGI1j7nqYWh/K5qz9Cmdg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h0oBrBQOUJz079b6heoflM/gKyoJysOpXq/sukmFtyKPRBm1JXv9FbXhnNoAaItXj 98j2i/kiHloV64AYBC1zOLFqZXhDkZfbVK9j27HIP+IiRSo++fG+xoYA2oh3XolzMV VkY18U4moqlbBrbuj6E8h5apfqlOpY8fyDrmo3Cw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Murphy , Mark Brown , Sasha Levin Subject: [PATCH 5.8 253/633] ASoC: tas2770: Fix unbalanced calls to pm_runtime Date: Tue, 27 Oct 2020 14:49:56 +0100 Message-Id: <20201027135534.535154925@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135522.655719020@linuxfoundation.org> References: <20201027135522.655719020@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Murphy [ Upstream commit d3d71c99b541040da198f43da3bbd85d8e9598cb ] Fix the unbalanced call to the pm_runtime_disable when removing the module. pm_runtime_enable is not called nor is the pm_runtime setup in the code. Remove the i2c_remove function and the pm_runtime_disable. Fixes: 1a476abc723e6 ("tas2770: add tas2770 smart PA kernel driver") Signed-off-by: Dan Murphy Link: https://lore.kernel.org/r/20200918190548.12598-5-dmurphy@ti.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/tas2770.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c index 8d88ed5578ddd..531bf32043813 100644 --- a/sound/soc/codecs/tas2770.c +++ b/sound/soc/codecs/tas2770.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include #include @@ -780,13 +779,6 @@ static int tas2770_i2c_probe(struct i2c_client *client, return result; } -static int tas2770_i2c_remove(struct i2c_client *client) -{ - pm_runtime_disable(&client->dev); - return 0; -} - - static const struct i2c_device_id tas2770_i2c_id[] = { { "tas2770", 0}, { } @@ -807,7 +799,6 @@ static struct i2c_driver tas2770_i2c_driver = { .of_match_table = of_match_ptr(tas2770_of_match), }, .probe = tas2770_i2c_probe, - .remove = tas2770_i2c_remove, .id_table = tas2770_i2c_id, }; -- 2.25.1