Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp267819pxx; Wed, 28 Oct 2020 04:33:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLdyNfkUv71mZn1kxcPlRbskuEWI8jQ6Sjyyze90OL5vpbDrfsGpDvsUNDgg7A0vcPWi+Y X-Received: by 2002:a17:906:86da:: with SMTP id j26mr7009904ejy.35.1603884839510; Wed, 28 Oct 2020 04:33:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603884839; cv=none; d=google.com; s=arc-20160816; b=HKEql+reoGqxt5EMDKwsRiCEkQo4MIKuwo3QKXCcENAb+p8Wxiw7GBl/0HvDkuGvwY ufK07QVC0sfwLYt7rQQTDkCCvWen8POTj44DcFnZNKvBDB+zK+scA9FBuog1RLRaSTXx aLweYssKp/KAW7bMqiC+GI0l/0gWUObZcEhyCw5uwIw44jRKQ6SjKTwvny0F2qWdpI1p +gaV3nC0HyCDglbI0xAwGTcPxkzys3y2axSwY8j2eDV0pg6LhP6TvK9MbeLT5Zd81RGH JtRdyDn/3cJlXz/eB7Kl4DYVb15qhKYdfkfskbesHa/WVTO+KC8Xf7ScK0HnrUp4M3yr FUXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Q3u/PsSUdq/LscRdEliu1XCRSsvVgdfq+tTTanhJBzQ=; b=cut7f+WtXENe/7eYjnljpZG2Z3mQxuJjGEhdDAp0HUhITyATPo7+pCCUD6cCqap+Gv KkITEmHD2nppbC15OZ6ZnlnXaufP9TYO9b2jwUPpYL1usL/TDMxvSb97zOhduM8TS/w2 pUvzQYVAbf9sNDOmzr5Dmj9BrodlTHkRel8uoYDzYy/4RnfWJ6+JbbjefofsCMZoSmdW DPdPqRpOGYwFYQovOKer54nMfhuZYgww81g6X837paJvW+lggGgBm8rOBc+P3eAtBmuJ LWkqpZHoYw1fs+g9Jxo9jSvws6AiEGXgGRZ9njrJfKuW6QCUqMGVaaR/a09eR5LW99d7 6nQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CgnS8MSj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs17si3022913ejb.543.2020.10.28.04.33.37; Wed, 28 Oct 2020 04:33:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CgnS8MSj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1793868AbgJ0PIn (ORCPT + 99 others); Tue, 27 Oct 2020 11:08:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:38606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1790223AbgJ0PEE (ORCPT ); Tue, 27 Oct 2020 11:04:04 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6FB9D22275; Tue, 27 Oct 2020 15:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603811044; bh=0E2Ykqa+snAZ4Uv+CiTsNJHfAbIcVITE6D9t4dRF2qk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CgnS8MSjkzSP+5tL+uOPLxzkApt0tLdoYV7ugfHxyalAPIBS48dhQzjthITdvgL1N 90QjfDdIPY+DZQhhCe6/S4xSA6erOydtITi7gkJ1Ssz5m3ixenYJlKmPC3UV/NVegU KBtqpHk+8JXEyNn6RGgiREvPePNE5vz6gvzaDxZc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michal Kalderon , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.8 354/633] RDMA/qedr: Fix qp structure memory leak Date: Tue, 27 Oct 2020 14:51:37 +0100 Message-Id: <20201027135539.293591423@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135522.655719020@linuxfoundation.org> References: <20201027135522.655719020@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Kalderon [ Upstream commit 098e345a1a8faaad6e4e54d138773466cecc45d4 ] The qedr_qp structure wasn't freed when the protocol was RoCE. kmemleak output when running basic RoCE scenario. unreferenced object 0xffff927ad7e22c00 (size 1024): comm "ib_send_bw", pid 7082, jiffies 4384133693 (age 274.698s) hex dump (first 32 bytes): 00 b0 cd a2 79 92 ff ff 00 3f a1 a2 79 92 ff ff ....y....?..y... 00 ee 5c dd 80 92 ff ff 00 f6 5c dd 80 92 ff ff ..\.......\..... backtrace: [<00000000b2ba0f35>] qedr_create_qp+0xb3/0x6c0 [qedr] [<00000000e85a43dd>] ib_uverbs_handler_UVERBS_METHOD_QP_CREATE+0x555/0xad0 [ib_uverbs] [<00000000fee4d029>] ib_uverbs_cmd_verbs+0xa5a/0xb80 [ib_uverbs] [<000000005d622660>] ib_uverbs_ioctl+0xa4/0x110 [ib_uverbs] [<00000000eb4cdc71>] ksys_ioctl+0x87/0xc0 [<00000000abe6b23a>] __x64_sys_ioctl+0x16/0x20 [<0000000046e7cef4>] do_syscall_64+0x4d/0x90 [<00000000c6948f76>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Fixes: 1212767e23bb ("qedr: Add wrapping generic structure for qpidr and adjust idr routines.") Link: https://lore.kernel.org/r/20200902165741.8355-2-michal.kalderon@marvell.com Signed-off-by: Michal Kalderon Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/qedr/verbs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c index 8092821680438..c6165c6390a71 100644 --- a/drivers/infiniband/hw/qedr/verbs.c +++ b/drivers/infiniband/hw/qedr/verbs.c @@ -2753,6 +2753,8 @@ int qedr_destroy_qp(struct ib_qp *ibqp, struct ib_udata *udata) if (rdma_protocol_iwarp(&dev->ibdev, 1)) qedr_iw_qp_rem_ref(&qp->ibqp); + else + kfree(qp); return 0; } -- 2.25.1