Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp286522pxx; Wed, 28 Oct 2020 05:04:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDQj/PTUaKHyfCh3TaG7gpFM4cbFZzoSbcLjPHZc4UKVjQRGWq0oRIy8ttgDbAqhIqeNB6 X-Received: by 2002:a05:6402:1d82:: with SMTP id dk2mr7056917edb.299.1603886639798; Wed, 28 Oct 2020 05:03:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603886639; cv=none; d=google.com; s=arc-20160816; b=pCMtuFmZ1b/PUj9OO7kumLeDBUYIVUHIZt4dGbwfEPFxIqZ+K2+1XhrVbsZnhbDo9u 8KAWELzNS18pf1v5ghSBSU2zA2zbP3/3xa/K5mPKiwibYByXOr/2MrZc/Ofnl8IgCY/j NdMrlUCEG2IL6XAEfn4e+E46NxcrWXOTqAdVGNIBYdfmdD7WizVsH3kLznErImChOF1j YciOXoND8crSigXaM4BUKsHJSAhzKdVZ4kpeO4cfsUXSV8JIdfxWaYlEXeLwV0sckaav G4ZN6MP6rQ71WsgGiIceqJBFw1amJqpXtLZqo6lqOyZwGJLXrX4ObiOeBqoDZ+eoyv1P gH6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aXbwBoztN3qHOJjmaL/D5HpiW+w6O1Rb53W07BY+2uM=; b=dv+vuvCHVjxfuBM6roYWQhRp2/+zwvoOWhBmYdTKMjiIS8v20BU1iL8i5+m1E5C2yL KT6m5qvDV+pYYoWzp2GATzUfgs4vAZanfhuR8wowL/xKWXFlAoDb+G2EWf94MVk5pm1f 7O4HsrMMy/8q1NtvLwfCKWBM668YKKufwoX3i/oy0lTYlRn4WD8RZbiMsVljU8P2vp/M lUAttoZynwRkXeUKqe8Xe9HqNH7yMFKXP6TsVHo+fk6wevbV1kk1ye0C3fJT2OOHk/dd DSuDG+/l4jZw04QPf9nIgbNq9ICHuEg++7dtvsoI1PKRbua1TNEYcYqWvRD5AOEG0v+Z Vlfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vEolh3UG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x26si2664388eds.99.2020.10.28.05.03.32; Wed, 28 Oct 2020 05:03:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vEolh3UG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1795218AbgJ0PPJ (ORCPT + 99 others); Tue, 27 Oct 2020 11:15:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:46010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1794185AbgJ0PKX (ORCPT ); Tue, 27 Oct 2020 11:10:23 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1ECE321D41; Tue, 27 Oct 2020 15:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603811422; bh=BHTx4gmv9FC4LZ7qW6B6Sv/WDNEepcUADy5PQP4DjDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vEolh3UGEalSyoyukx8k64++3kxJRmeAZ4j0S9lKVFyeHXO5AWwYrTx5kfzMWJU6W xvtT+QfTouQY7MSNgYsbWwEvXteCdKRsSVpwg+Jdq3xeHiK6Sk+U2YaDyePlnMdtZp qBNYd24LS8a5xZPDirJZoX4wpiGv80yI53Hp0RDM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Roger Quadros , Krzysztof Kozlowski , Sasha Levin Subject: [PATCH 5.8 488/633] memory: omap-gpmc: Fix build error without CONFIG_OF Date: Tue, 27 Oct 2020 14:53:51 +0100 Message-Id: <20201027135545.632324272@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135522.655719020@linuxfoundation.org> References: <20201027135522.655719020@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit 13d029ee51da365aa9c859db0c7395129252bde8 ] If CONFIG_OF is n, gcc fails: drivers/memory/omap-gpmc.o: In function `gpmc_omap_onenand_set_timings': omap-gpmc.c:(.text+0x2a88): undefined reference to `gpmc_read_settings_dt' Add gpmc_read_settings_dt() helper function, which zero the gpmc_settings so the caller doesn't proceed with random/invalid settings. Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT") Signed-off-by: YueHaibing Acked-by: Roger Quadros Link: https://lore.kernel.org/r/20200827125316.20780-1-yuehaibing@huawei.com Signed-off-by: Krzysztof Kozlowski Signed-off-by: Sasha Levin --- drivers/memory/omap-gpmc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index b5055577843a2..27bc417029e11 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -2274,6 +2274,10 @@ static void gpmc_probe_dt_children(struct platform_device *pdev) } } #else +void gpmc_read_settings_dt(struct device_node *np, struct gpmc_settings *p) +{ + memset(p, 0, sizeof(*p)); +} static int gpmc_probe_dt(struct platform_device *pdev) { return 0; -- 2.25.1