Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp295105pxx; Wed, 28 Oct 2020 05:14:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyq/huEvilLjJtJ4UXopgWzTG6UBpdUeAzJ7UepLKeHghu09VR2b+gA5rwSVK0Hv10XmkR/ X-Received: by 2002:a05:6402:13cc:: with SMTP id a12mr7446403edx.73.1603887290206; Wed, 28 Oct 2020 05:14:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603887290; cv=none; d=google.com; s=arc-20160816; b=o6ktyNlMbXfZmtQ9kDXVgPUlANHovgZQa9p/TsYnupIOu4wyF9RtUnxVMaGvpKHjyW TeVhhjWkJVVP7xmMqwSVD6EUac5fbsqXhTW7ep7zoiwCNmkxxvSJsODyLsAQRu6qM647 8N15NE+ow9p3bITh4rFDvOwEk2mBnScIQA6BGKargYUDlarAC0J/f3bDcPgWogXDqCl0 e9kD0riM1qgPe0IzVCtdg/KKhvKsaLOJAITchnpnYwFPoXQOuzx64SajuyhL6Q+nTqLH udD4n161sXOON7wnmN5J/opy1+cqZdTnpAzKehUDuIWpCQgU0Ut1/nEBQVGRXZGSnzrX ZvZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=1bxc1CbEhMGtJupeCLQxLyu21YkEMc+WCBT4UAmtdyc=; b=uc9GuFvE4yGu2P6qqG2ZiOyhHB3zazc7vKP3ulFRC2M34htx5zyfmO87twu0XVBSZ4 ETINsP3L6m/qqRVE/NMlk0rcExZIzQ+Q3FbBewk7xBLxO0CfNMlah0dgpUdKQHaTq1Fx NKHtfi4dZA8J26floo/pZlVngB9pMNSH2Xr/JQIV0OWvBD6sX0W9vF/+E8r0Oyroaz7f 9SZqfeCWMMY85FoHtmMCvVPgxspYfnuRi13ILrlG7NMbQmQsgXkBKPrry1fSmsZRSoR3 NXnD9VMUNI7QcQiLdwRMWoi3oA+iycvVymzjWgf2WKbK91x6ID5QojcgHS+/S5m0OGdF tT+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b29si2827715edn.354.2020.10.28.05.14.27; Wed, 28 Oct 2020 05:14:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1795975AbgJ0PPe (ORCPT + 99 others); Tue, 27 Oct 2020 11:15:34 -0400 Received: from gecko.sbs.de ([194.138.37.40]:46295 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2508584AbgJ0PMz (ORCPT ); Tue, 27 Oct 2020 11:12:55 -0400 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 09RFCk7M000972 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Oct 2020 16:12:46 +0100 Received: from [139.25.68.37] ([139.25.68.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 09RFCkiQ015696; Tue, 27 Oct 2020 16:12:46 +0100 Subject: Re: [PATCH 0/7] gpio: exar: refactor the driver To: Andy Shevchenko , Bartosz Golaszewski Cc: Sudip Mukherjee , Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Bartosz Golaszewski References: <20201026141839.28536-1-brgl@bgdev.pl> From: Jan Kiszka Message-ID: <1fd4d69b-4d64-05e5-45a3-b2182fb2d207@siemens.com> Date: Tue, 27 Oct 2020 16:12:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.10.20 15:46, Andy Shevchenko wrote: > On Mon, Oct 26, 2020 at 4:22 PM Bartosz Golaszewski wrote: >> >> From: Bartosz Golaszewski >> >> I just wanted to convert the driver to using simpler IDA API but ended up >> quickly converting it to using regmap. Unfortunately I don't have the HW >> to test it so marking the patches that introduce functional change as RFT >> and Cc'ing the original author. > > +Cc: Jan, AFAIR their devices are using Exar UART. > Thanks for CC'ing. I cannot promise testing this soon, but I will try my best. Jan >> Bartosz Golaszewski (7): >> gpio: exar: add a newline after the copyright notice >> gpio: exar: include idr.h >> gpio: exar: switch to a simpler IDA interface >> gpio: exar: use a helper variable for &pdev->dev >> gpio: exar: unduplicate address and offset computation >> gpio: exar: switch to using regmap >> gpio: exar: use devm action for freeing the IDA and drop remove() >> >> drivers/gpio/Kconfig | 1 + >> drivers/gpio/gpio-exar.c | 155 +++++++++++++++++++-------------------- >> 2 files changed, 77 insertions(+), 79 deletions(-) >> >> -- >> 2.29.1 >> > -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux