Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp321016pxx; Wed, 28 Oct 2020 05:53:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIZSNutlr0g9FvxfpLzU6EP3U036lcKCjSbt80tr4BK4Y1kR/6CeWlEE+xRqp5LNARnuqV X-Received: by 2002:a50:dac1:: with SMTP id s1mr7605823edj.74.1603889588353; Wed, 28 Oct 2020 05:53:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603889588; cv=none; d=google.com; s=arc-20160816; b=zSEu5kDmPYIJoZ927eyQc71axwRfnLysXckVO1A34j85zZkKpXaiqIsL2wYNYU3NQf HgDMVOqQkTalXQyGUHdN45TLhZdRrAEYCjwnTb6ccWZjzuJu8fqL0FmkUz9i1PBPKYOH KrAyif151Z6fubcrJx9VBDySjyFSzkfNLtBZhmTVeizPeGs1SkYeCR09vdbSVOZ0Ueid eoo9CR5n7x7WqxlE+aMXCrsMMJj3Of0CRSCZz1ygcarFpKb89vwMxtJVN1LxacHkgzk3 MoE1x6KyGyI1Bkc+ihsq1ooJxfS2akK4eDZfjF9Ay/HoOF0uHpfh+hnWgRwkvXotN5/R E3Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VjIQzVHMtETJnYkqFVXica1twCSSwZ7TCvYGB6HwYhY=; b=hfX+MWyUXzO7HIBYkhyKfTkftji2Jdw3zGx6thnZtECfF7JEBlFXpQfOt4m6cvKr9Q ZpwbJIk4hsTFKrRNMQ+jXVSuVi6tA+800LF1JEDYKpwiROvNkavy3DVA0JjoILeku7tk eG3fECBKuQPPF1mxljTG3L1EC8gnFlSeNjXZcfS32jFsALb8bwoME6HWVRGUvZCfriHR hX5Gt5mgSiNeMZkjUgvUkZk/p0ubGYd55GJ1Vs7vpFBUBRd/5diFAjcfiZ80V6fEpCi2 UTW2utq/+NdHmmMvZ2Jkrg7t2O8gpaP8wIb5SEhfWwdNoh7FR6ZMGxCEIhNJWNYt0pHI a2vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Q/0pvupA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f19si2736409edx.542.2020.10.28.05.52.46; Wed, 28 Oct 2020 05:53:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Q/0pvupA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1799459AbgJ0Pbh (ORCPT + 99 others); Tue, 27 Oct 2020 11:31:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:36594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1797151AbgJ0PVw (ORCPT ); Tue, 27 Oct 2020 11:21:52 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BABB21527; Tue, 27 Oct 2020 15:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812112; bh=U3vO92lsyXzc2mm4IVenesA7XJKdMDlQWyd4Ek9E9qE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q/0pvupA7nPNnFgxtl82kFc8gY6Gr0XPQowEN6kuNpYXoxhq9NEQO2wkmd4ph31Qb 969Vy3d507FNaaa2eY7lMrAm1WSTX7NaHDBk9YFKgK+vR7OUiRXF2Y1dju9r82Wu8g VH5pACiitmhVOwUXyE+OdhUbfZ4laXg9wR/PAnF0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Marc Zyngier , Lokesh Vutla , Sasha Levin Subject: [PATCH 5.9 096/757] irqchip/ti-sci-inta: Fix unsigned comparison to zero Date: Tue, 27 Oct 2020 14:45:46 +0100 Message-Id: <20201027135455.052013671@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit 4c9b1bfaa5039fee650f4de514a8e70ae976fc2f ] ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq should be int type. Fixes: 5c4b585d2910 ("irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC") Signed-off-by: YueHaibing Signed-off-by: Marc Zyngier Acked-by: Lokesh Vutla Link: https://lore.kernel.org/r/20200826035430.21060-1-yuehaibing@huawei.com Signed-off-by: Sasha Levin --- drivers/irqchip/irq-ti-sci-inta.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c index d4e97605456bb..05bf94b87b938 100644 --- a/drivers/irqchip/irq-ti-sci-inta.c +++ b/drivers/irqchip/irq-ti-sci-inta.c @@ -175,8 +175,8 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom struct irq_fwspec parent_fwspec; struct device_node *parent_node; unsigned int parent_virq; - u16 vint_id, p_hwirq; - int ret; + int p_hwirq, ret; + u16 vint_id; vint_id = ti_sci_get_free_resource(inta->vint); if (vint_id == TI_SCI_RESOURCE_NULL) -- 2.25.1