Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp323805pxx; Wed, 28 Oct 2020 05:57:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8AYqu4ecD669yw/owKgLxuhn/x2Fd9a/V7j+Bz+OkH3roD9K+1vQPHMQGk0ZhJsqQfkDD X-Received: by 2002:a17:906:3294:: with SMTP id 20mr7276948ejw.322.1603889831883; Wed, 28 Oct 2020 05:57:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603889831; cv=none; d=google.com; s=arc-20160816; b=kGv1igV1kW8DXq+S3lwYA8jC85fDq3TPq6tN7hjHbKC6M+/8pShPZqBMDYMMCeDaZB S8h4MD+bU2bM82idnHmt57+SZbCzA4TzmhRiEPLWY84n+4KdjIIUPYeOgjlx/uMo2Yjg hA/xeSiR94PHXFGv2iQJvJBw1ClMZFEjPXw+egLN5OAD+wtIjZ3BzBUGQCQ/nXxCxjer xjuXw3e/ajd7/aTk4VekdMWr65eep+2MysRbeA8rzL/9dpgjTMDz0XjG6WuL+yjmL5qA B+FuDrQGFnWRY026k+RJK2AgbkyfsNvxEzFKQeHCCMp7dVuKxGszWmJMngrkk9bCyzP1 3RcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gl4PBG3xb5VpudNxStB33nPf2ZkZutPrcQWVVY2vKmI=; b=HJFxKzl8aYcjOl6gSwVFiEkOWUj55xuGZBgcpWKK0ONVKhAXlbpsGRxUp5zcwgxoBc FX5hM27TRKo9ai73bWEzCiLLPq9RQgKBc86gwphJJJQUuBX9IyPjS7J2qt47CT7k22F0 P5oYwuVb2DQrqxST5VrrcSQd5VzXCKhrOO1tYEbGmWgdmFmxN54mtlzxzfYOYZD9oqjK sog/P3KicGXSk/52ItD8Dos50xDqfwtrM7FcSixgpVtBo7YgYRnAT8GbEo/pVWFYAJB2 RrXD2VCys/YihaZO0Y8UrG9OBt6h6YPrETrXhwEX2sghl/8d6P91RI19PcMHGn86onLY rvnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xmT3Y89L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lg14si2653130ejb.82.2020.10.28.05.56.49; Wed, 28 Oct 2020 05:57:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xmT3Y89L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1799655AbgJ0Pcm (ORCPT + 99 others); Tue, 27 Oct 2020 11:32:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:41022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1798150AbgJ0P0N (ORCPT ); Tue, 27 Oct 2020 11:26:13 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE0AE20657; Tue, 27 Oct 2020 15:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812373; bh=ml0WXOPEPyk5UVVFixp6s8DuJPKjVpg0UlZkG48Mp2I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xmT3Y89LukxUTlwJE4UfPtsHASJ8bSnAA7kQErFbBNWRFlFZUX01Y5oAFFP5BFXke 7J6Hy6nC4nsqWUFDbjyKOL0BsUDQw88PxSnmS6AbZmx0ep9nRdDx6DejOQNZNp7eIa bvp9R0COv7yAi7GbKxQ3B3ZV4W4eE8rsUZIrryRw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qinglang Miao , Daniel Vetter , Sasha Levin Subject: [PATCH 5.9 187/757] drm/vgem: add missing platform_device_unregister() in vgem_init() Date: Tue, 27 Oct 2020 14:47:17 +0100 Message-Id: <20201027135459.377597678@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qinglang Miao [ Upstream commit 57fb54082d5d14512dfd21bc39d91945d3ad1ee9 ] When vgem_init() get into out_put, the unregister call of vgem_device->platform is missing. So add it before return. Fixes: 363de9e7d4f6 ("drm/vgem: Use drmm_add_final_kfree") Signed-off-by: Qinglang Miao Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20200810125942.186637-1-miaoqinglang@huawei.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/vgem/vgem_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index a775feda1cc73..313339bbff901 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -471,8 +471,8 @@ static int __init vgem_init(void) out_put: drm_dev_put(&vgem_device->drm); + platform_device_unregister(vgem_device->platform); return ret; - out_unregister: platform_device_unregister(vgem_device->platform); out_free: -- 2.25.1