Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp324255pxx; Wed, 28 Oct 2020 05:57:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3XvNPbGHjVheEAC33pJvCjQUvdSnvGYprD+945K7gc6hVyvPTVvIx/+rqr/Ri76ST6e5I X-Received: by 2002:a05:6402:6ca:: with SMTP id n10mr3259454edy.314.1603889871362; Wed, 28 Oct 2020 05:57:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603889871; cv=none; d=google.com; s=arc-20160816; b=Gu3kp+XaJ1e68k5ixxIh4Qdm6mNF7b5SAfz7U3UOl5ltnyx7dFzWRVryXdaJjluOci /mY6LIMrMmOABNLUSaYQWYJUobybrop4Q+od4Cg8FTQ8urALZPvUfNOidwHz7PPNh8VH T0G3VMkvyRoqKsBWCGNcWa8QtUJr+tWJ6kZ2DS6jZXK9u/FwD+ZOjhKkwTm0KGoc4UPy 0G2D+ac7JGr+JRm8LVnHASbaXyc7eKMGBxDECoDYLuAmfb9m3mOUCfXC8dgXm0E4tLqF gGUy8BFNZo+Uaw/nXd+pT9n/zMJgcWLNZJ1EIOISMwvbiynZ54dZGrlB/wfu8U/YIQ1N jemw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=o/Fe0O4blXcSfo+kSR/GdOuEg4X/lp+8NlcRE9pstao=; b=JDZx+9ZdhyGhezgxxLBAUQYp2+GPlTJDQIu+fYLnaQknwFBZH2KVwWrCSIOV8AAb5V XWfK3TrY5PGwAbAor8oTzvHsvhU63hKmoMMMNVeq/eD0Nfj8cs7wntmow+9+JDU7oBCG W5UJOsZItGtP1TgG6pUn+KgX8tsC5YtcvZbvGq6sh/4gon1m1Z5s2mSgkc5TmT+vvy3k l3HpbL4wczM13ADFIjAni1DYesldIlx3lqNuGgtfLvPRkXcb7+cpbN+xeAniZHaAi81i pMOM7eBIZU+EJBymLLYBbngLX2y7XwyX72VNQZAVynF5URCqqT9fxh3RXB1wO8jWHBzJ e+Ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ErIllKf9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o10si2705925ejr.482.2020.10.28.05.57.29; Wed, 28 Oct 2020 05:57:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ErIllKf9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1799678AbgJ0Pct (ORCPT + 99 others); Tue, 27 Oct 2020 11:32:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:41044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1798156AbgJ0P0Q (ORCPT ); Tue, 27 Oct 2020 11:26:16 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8EC2722202; Tue, 27 Oct 2020 15:26:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812376; bh=zxxk1RlUkayOgyzA1AzJFPbckdqjH5o8ahkcI3T1syA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ErIllKf9THcIDnBinXRZNpB6E9XoKIfX721KfluZWIQ+NDrBxZH1UMpElY10piuCh o29t0DeVQMG+SXXnOSG0o+IWezCH6o6yUzsmDiXzzwHuJrfGDpjfl/4Kor7llLBIi/ lPN/nyGsPiUzoVwkfZTtlBPf3Blsfq+yID554l3I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qinglang Miao , Daniel Vetter , Sasha Levin Subject: [PATCH 5.9 188/757] drm/vkms: add missing platform_device_unregister() in vkms_init() Date: Tue, 27 Oct 2020 14:47:18 +0100 Message-Id: <20201027135459.425783923@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qinglang Miao [ Upstream commit 7995bd13296111d672d8c5959f5e81dbbbda5286 ] When vkms_init() get into out_put, the unregister call of vkms_device->platform is missing. So add it before return. Fixes: ac19f140bc27 ("drm/vkms: Use drmm_add_final_kfree") Signed-off-by: Qinglang Miao Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20200810130011.187691-1-miaoqinglang@huawei.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/vkms/vkms_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 57a8a397d5e84..83dd5567de8b5 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -190,8 +190,8 @@ static int __init vkms_init(void) out_put: drm_dev_put(&vkms_device->drm); + platform_device_unregister(vkms_device->platform); return ret; - out_unregister: platform_device_unregister(vkms_device->platform); out_free: -- 2.25.1