Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp333207pxx; Wed, 28 Oct 2020 06:07:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPjou9zcTO7ZQdF3WPbo6rULaSY/BlNshphj5Fe9QYDIaRk18gW9o73YpLUZwHMrOPoXKu X-Received: by 2002:aa7:dcd6:: with SMTP id w22mr7547448edu.378.1603890475812; Wed, 28 Oct 2020 06:07:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603890475; cv=none; d=google.com; s=arc-20160816; b=cvhrZYG9WoPP3EZCvNnblCFIA/F6IeFp1JPtzCSMyMFL4UZUxJejiFPbQk467VEYTU /gmkWGL0W+etOR4u9jXPgkXJELSkFuQXZjz7Ej0eXYUb/bqnckHao4SxNCqcXe2JY9vC KhSfw1YJOOMuJKtKT+j2Itithx52Rq+dArVr9KJ+IYbI8w9k2fcNb/EP8gyW5FiGYpIu 2u71AP6ulgcpvRB7oh4Ksg9/9iqLaC6ATAKp7MIkV4IFgeWKXRZQyQ1crCnE4BsQuXx7 Wnok6Rc1DTi/vWTFgw2REP+mw7C4G8FHnBgIiGnhPEEgPf2gZlgESmRKGjHTuZvVbM3/ VKfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4P9j7hJWYT81zYhnhNw/afScHJ9oaQw7C25a14yWIu4=; b=Iz+0gLFYwh01X8hjOFK9r8exTmcOMi0CFkSo5uk/qUXMZKX7j9uN8EZi0nk5SH4LYm H0e9AmhFqyQfA08EwksXWDEMM0g9sP2bzY1jwNyspXJ5kjEevuh7qgLKESrC8YuKsFFL QcDt1grPRFfASuUYoNocQA6It/Dn6ToZfg7OZ7bo3+0bax0sAPLypsYMDh0pXjQwy3RT ws/KOOMTMtvMUyAbUT8+ZLK3R+CVYtkN/YUnNNGF9BeZYVFE1cKt4pgircPT1kKl64uC I3pUCRKhD76ZCrEM3hHmfuWvt0gRhKpcFKBELydDgGtGDQ6W8kaGtG0gnZqOnw0hDPYD FouQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VQDjZ9JN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d4si2698178edr.173.2020.10.28.06.07.32; Wed, 28 Oct 2020 06:07:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VQDjZ9JN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1800047AbgJ0Pek (ORCPT + 99 others); Tue, 27 Oct 2020 11:34:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:45776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1798640AbgJ0P3Z (ORCPT ); Tue, 27 Oct 2020 11:29:25 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 56AB822265; Tue, 27 Oct 2020 15:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812562; bh=VQm14qtVacuW3r+j/TtBKQUVM9VZTzzkQQAVNEhmsIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VQDjZ9JNkda/0beu2Kz2+bjngsmoHEVCujcBcCNFyNLh8mBTFgP/TIMU72vqIhIIy hbLu7IINJXyUMWvtEmhnoG0Nu6pz/mFoyDBLXNZVcJPDqTNEdMg7rf0moB/d1xna04 PVlrRGY91I8+hP7r23IgEc1oHF/YPBveuRkhGl/I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thomas Preston , Andy Shevchenko , Linus Walleij , Sasha Levin Subject: [PATCH 5.9 254/757] pinctrl: mcp23s08: Fix mcp23x17_regmap initialiser Date: Tue, 27 Oct 2020 14:48:24 +0100 Message-Id: <20201027135502.486076876@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Preston [ Upstream commit b445f6237744df5e8d4f56f8733b2108c611220a ] The mcp23x17_regmap is initialised with structs named "mcp23x16". However, the mcp23s08 driver doesn't support the MCP23016 device yet, so this appears to be a typo. Fixes: 8f38910ba4f6 ("pinctrl: mcp23s08: switch to regmap caching") Signed-off-by: Thomas Preston Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200828213226.1734264-2-thomas.preston@codethink.co.uk Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/pinctrl-mcp23s08.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c index 42b12ea14d6be..87cde8fb08dd9 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08.c +++ b/drivers/pinctrl/pinctrl-mcp23s08.c @@ -87,7 +87,7 @@ const struct regmap_config mcp23x08_regmap = { }; EXPORT_SYMBOL_GPL(mcp23x08_regmap); -static const struct reg_default mcp23x16_defaults[] = { +static const struct reg_default mcp23x17_defaults[] = { {.reg = MCP_IODIR << 1, .def = 0xffff}, {.reg = MCP_IPOL << 1, .def = 0x0000}, {.reg = MCP_GPINTEN << 1, .def = 0x0000}, @@ -98,23 +98,23 @@ static const struct reg_default mcp23x16_defaults[] = { {.reg = MCP_OLAT << 1, .def = 0x0000}, }; -static const struct regmap_range mcp23x16_volatile_range = { +static const struct regmap_range mcp23x17_volatile_range = { .range_min = MCP_INTF << 1, .range_max = MCP_GPIO << 1, }; -static const struct regmap_access_table mcp23x16_volatile_table = { - .yes_ranges = &mcp23x16_volatile_range, +static const struct regmap_access_table mcp23x17_volatile_table = { + .yes_ranges = &mcp23x17_volatile_range, .n_yes_ranges = 1, }; -static const struct regmap_range mcp23x16_precious_range = { +static const struct regmap_range mcp23x17_precious_range = { .range_min = MCP_GPIO << 1, .range_max = MCP_GPIO << 1, }; -static const struct regmap_access_table mcp23x16_precious_table = { - .yes_ranges = &mcp23x16_precious_range, +static const struct regmap_access_table mcp23x17_precious_table = { + .yes_ranges = &mcp23x17_precious_range, .n_yes_ranges = 1, }; @@ -124,10 +124,10 @@ const struct regmap_config mcp23x17_regmap = { .reg_stride = 2, .max_register = MCP_OLAT << 1, - .volatile_table = &mcp23x16_volatile_table, - .precious_table = &mcp23x16_precious_table, - .reg_defaults = mcp23x16_defaults, - .num_reg_defaults = ARRAY_SIZE(mcp23x16_defaults), + .volatile_table = &mcp23x17_volatile_table, + .precious_table = &mcp23x17_precious_table, + .reg_defaults = mcp23x17_defaults, + .num_reg_defaults = ARRAY_SIZE(mcp23x17_defaults), .cache_type = REGCACHE_FLAT, .val_format_endian = REGMAP_ENDIAN_LITTLE, }; -- 2.25.1