Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp334558pxx; Wed, 28 Oct 2020 06:09:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFJFndYIdjYozvHsswr3/i2sb1Egdtd3e5pqGic+fqbd6OqBEnwm7rOzd6NUk9RfuIajHE X-Received: by 2002:a17:907:4273:: with SMTP id nq3mr7600204ejb.439.1603890569451; Wed, 28 Oct 2020 06:09:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603890569; cv=none; d=google.com; s=arc-20160816; b=BVYg/webe9ZC152KHaiJ7mcdonhNQgcEwflv3CXIy/b8iYThbwuOw07vUDVpYh60y0 R8V4l+AQrIoSFB3IfhZvft1168e4PbizoNRomG4/VQA9sopm0Mi4vtajWNz2fFw4v4Gf dgRvYZTRVk6acofoyAjGggB4Uh2m/aNNuZNqhWnsJJTH2ufDzip+0RKLzDshwgYe/w/s 90E+Mp8Ze7sbC4UjPDcLrgjdejF3qE9iNmiYhI5wKj9Kk3aUjVr7gJP/IfBEIVCGVcf1 3ZuD5vvGnvQv2D0KVM5AKulrELJEoJKedyamordmGjBnAhw/c0odFq/gEES53XqNkgA0 QpMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=H5LrHw3N5tSkz7ylMcodVbWMQZ9lnIG5mrugDoIF648=; b=yAYP4pz58GE8A4TyU/qnF1qxvhtaw2o3J7JEfFsau56ZJ1VhxXtddDIH9RXucVF5Kk j6AYBnFYRtjGOpGxiDC2Ko76O/QrM45nls1AnfglAI4FmDkrmMuk7z3TixlNLVub820G /e7N3SKFu0G46xaRNZ7Wl6pmey72lRV7gJ5Kd4/0VDv3JG7urGKFP5PQ9tL4befkuftS J/7VtxOQlsQccTkOZKACSuX5Ml1wFY/jigdNO0y86rHBd2Be408cKwItCijh7iTYtE0h prZ8TPFrq/fOmsCUZY8x1SFv3pgus22sm/sBjlsugI95hdQg/GWNcADKx9tW5ZOP6gDs Xl3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZrQ3j+GL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d4si2698178edr.173.2020.10.28.06.09.06; Wed, 28 Oct 2020 06:09:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZrQ3j+GL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1800063AbgJ0Pek (ORCPT + 99 others); Tue, 27 Oct 2020 11:34:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:45814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760280AbgJ0P31 (ORCPT ); Tue, 27 Oct 2020 11:29:27 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 381F020728; Tue, 27 Oct 2020 15:29:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812565; bh=GEWsL5kHeaGNnM9fbhUycWFM/b/snUlx/WOb6hN3K6s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZrQ3j+GLnWAyvWFEbSs/600E2TjvV3srJK1CiPpCvp68gSNINr080t2zqLQXZijA4 aKG7OQKKya5VcAs8ZPFPyuyPQNCce8/iXV8IaMU7LcKcyGNCOdLF/EgrmiaqNPp1hH xudlOP9BFUHq/iQZTNzclnFzlpEBACUN5UIsnyyM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thomas Preston , Andy Shevchenko , Linus Walleij , Sasha Levin Subject: [PATCH 5.9 255/757] pinctrl: mcp23s08: Fix mcp23x17 precious range Date: Tue, 27 Oct 2020 14:48:25 +0100 Message-Id: <20201027135502.533761359@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Preston [ Upstream commit b9b7fb29433b906635231d0a111224efa009198c ] On page 23 of the datasheet [0] it says "The register remains unchanged until the interrupt is cleared via a read of INTCAP or GPIO." Include INTCAPA and INTCAPB registers in precious range, so that they aren't accidentally cleared when we read via debugfs. [0] https://ww1.microchip.com/downloads/en/DeviceDoc/20001952C.pdf Fixes: 8f38910ba4f6 ("pinctrl: mcp23s08: switch to regmap caching") Signed-off-by: Thomas Preston Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200828213226.1734264-3-thomas.preston@codethink.co.uk Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/pinctrl-mcp23s08.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c index 87cde8fb08dd9..7edb067f5e76a 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08.c +++ b/drivers/pinctrl/pinctrl-mcp23s08.c @@ -109,7 +109,7 @@ static const struct regmap_access_table mcp23x17_volatile_table = { }; static const struct regmap_range mcp23x17_precious_range = { - .range_min = MCP_GPIO << 1, + .range_min = MCP_INTCAP << 1, .range_max = MCP_GPIO << 1, }; -- 2.25.1