Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp337281pxx; Wed, 28 Oct 2020 06:12:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4Qaf1T0gqm1wnnZRTZuYelA1av7bQuGOp079cNC4nmZGg3MslA2XqMRZCsGdXXdYOnkIE X-Received: by 2002:a05:6402:1482:: with SMTP id e2mr7910617edv.36.1603890748387; Wed, 28 Oct 2020 06:12:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603890748; cv=none; d=google.com; s=arc-20160816; b=iK0+Xrgt/U/EdAa1H0csMflVyzKqYTMlMKh8d9bBtf8Zs5G40HQJxAg46dr6O5NTiP Jsato2ftw8dpXJ7vNeop2eM22s8zV6UWam+2qG9xY6Zx0QI71EkN7qtnNbUi2dXXcaOE 3PpZAiVYHnGQ+xgMHSnxyLB0FWHInJBMhD80WxnXtBaGCubMd0E0fec9kHbxsVaknuCB q9nXCdV0u4+wHmg8Fg8JCSjKUxRjulyyX/mYtwWu8IZgYdTc4drPw42s3B2m1J24Pxaf 5F2Nw97ysdNBk3w+KvlxFKbLN+5EL+Pv97Ejncbh38rcPHIiYh3DYnZVyqDwdLl7FCWT W23w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SnlnV9dPtG1JAvzyzN7BWEJbddnfINqDgmIkp3HxQ3Q=; b=oWBNqLN4OoblHf+DJcz80eD1UB0I+DzLutLMU+jIPO2ISPOZ1UAXmoUbW5e8qpYhJH l8nebLIgf8MRkiA/wZ29ZA+SbqU1oqp7/N1n2UUcxylgIozk9jNuDAhgsEvfKyUot/m4 B+utbYmniN2ASDkWn+ZCo3e9Xxuucd9THcHLm30i5bsQX8cUQ1LHpnZ0n66ymtJrs769 jdfib76jtQdoTncV/+RCzdtTfeTCzmI5+aWmjhMLHriw3Yzfv0AXFS86cIeh3cmeQYl/ l1Yd5LExZ8ZEnaqcOOgL/Iuo7OhmxQNXc6plEHM1ihjwTRS01MU6v8dbtk3CpRTzjnN7 3vuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z8G7mwMF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s18si2795558ejd.147.2020.10.28.06.12.04; Wed, 28 Oct 2020 06:12:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z8G7mwMF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1800155AbgJ0PfL (ORCPT + 99 others); Tue, 27 Oct 2020 11:35:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:47266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1799242AbgJ0Pac (ORCPT ); Tue, 27 Oct 2020 11:30:32 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9755422202; Tue, 27 Oct 2020 15:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812631; bh=sf3VC+nwrPX+O03St19gwI+xX2u5Mdv2WqUkhCYlVfs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z8G7mwMFJFpSzrdpv85xqI+kKgSZ8E4TXhh3lMilRiq+jjR5v5XdF68sRs3TAYUJV H/rsSAXqWwFhUuL9vZ+XMYqZYdMnW66XejisHorKJPDEd/MeSBoYq873lZW2zSO2Yx qFgDCxjL1qkKDf2RJpXz3IOvvghMJSuec24WzGtc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Kalle Valo , Sasha Levin Subject: [PATCH 5.9 246/757] ath11k: fix uninitialized return in ath11k_spectral_process_data() Date: Tue, 27 Oct 2020 14:48:16 +0100 Message-Id: <20201027135502.126264781@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit c7187acc3cd08a17e7b506b2b5277f42d1504d29 ] There is a success path where "ret" isn't initialized where we never have a ATH11K_SPECTRAL_TAG_SCAN_SEARCH and then ret isn't initialized. Fixes: 9d11b7bff950 ("ath11k: add support for spectral scan") Signed-off-by: Dan Carpenter Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20200619142922.GA267142@mwanda Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath11k/spectral.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath11k/spectral.c b/drivers/net/wireless/ath/ath11k/spectral.c index 1c5d65bb411f7..6d6a7e34645f2 100644 --- a/drivers/net/wireless/ath/ath11k/spectral.c +++ b/drivers/net/wireless/ath/ath11k/spectral.c @@ -773,6 +773,8 @@ static int ath11k_spectral_process_data(struct ath11k *ar, i += sizeof(*tlv) + tlv_len; } + ret = 0; + err: kfree(fft_sample); unlock: -- 2.25.1