Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp353576pxx; Wed, 28 Oct 2020 06:33:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSR+ajgC4FK3h6FvGTfTyhYRVJMVzAnguQnVi61CvywWlTitY/saXfqdp4BjFkrXbytTNp X-Received: by 2002:a50:cf45:: with SMTP id d5mr7536318edk.225.1603891995168; Wed, 28 Oct 2020 06:33:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603891995; cv=none; d=google.com; s=arc-20160816; b=FwP/xrngy+Jj1LwyELGkTU/kpOq3bqV5EIcLSIpPwdiaUEV8iM6FSZEnt+A3pgxKvK CW9BYamK4kZUVxmmSgd9Avz+0qlY/QsM1k+JzY4y+amnelh4SiZHzUSoIs7xrqCR5wXx t20bFr2XIqy5i7vjnMy5zTeHP2I9UBTFmPcNk+DkrIoT7iFQxuIoKuYKTTBd1Tm/NvOZ +PvD1h55rozpaQiAxxpNdKI1vtcGYLfc9s9fdxDKRs734doPU37Hgp+aM552zHCxRJOZ 09kw+DPoDyYheLjCz6r4Bit0eCIGbE+YhA0owQOJpAf8qJJg9VH+4b5wa5nGNhF7IUKU AyDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PPKcn/1UcDe5Zay9OTYtzB4hEKv3iHadImUMTO1+8sI=; b=WDSiAItSB7L0wt6uafdliIAAQGHmZra1JGWbxUEGbXCv4QrqSEW8/K3Mw9qF7ASs8y UpnRQ/wvrSN3RKlD0CHN7NLQ3jLzrrCPPIw/ZqxbMqaqFPrBt2vVZZq2es8RUauwQ32F 5XpK5Q/GgDAKqxN4RrxpOEmY57bPV5kO59mkC1ZNi4GjmijDlCPjbbwsiHWlNq0phohP Xc+TsxeSqg+0j5yt7YnHhM6asTyxHZMdfvnJ8kbpMK+3nROklW6jeuRs/VB9HHltCCsk z0dD882adtrIsYbMxkboGMbX6F7c8/1Mw0qNVhJIrHDWTd9t6xCxWUjQ7eszzsOFxzKj Wkkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="wyI74Tm/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk22si2709939edb.258.2020.10.28.06.32.52; Wed, 28 Oct 2020 06:33:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="wyI74Tm/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1802296AbgJ0PqI (ORCPT + 99 others); Tue, 27 Oct 2020 11:46:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:55424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1800537AbgJ0Pge (ORCPT ); Tue, 27 Oct 2020 11:36:34 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4BBF2064B; Tue, 27 Oct 2020 15:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812994; bh=2lf4uteV6LmPGW8kJ4FDcqRiQ4UcrmxFVigvV/E+Bqk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wyI74Tm/lFAmKpgHBBpZH03WxsZEnus9YpQFQu7cwC3LYHCJv+HgleXk5q/XNBXvU dveB2wVm+NeJfsVnCZkRDok4QF7ydyNmN6ExYrfAbSOyCyzJ2xWzxjVKcgH+8+wvm9 O6MeGMpUDw8iJDwGQBdMP++NHLr9TqhjtLSNFR2o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicholas Mc Guire , Michael Ellerman , Sasha Levin Subject: [PATCH 5.9 401/757] powerpc/pseries: Fix missing of_node_put() in rng_init() Date: Tue, 27 Oct 2020 14:50:51 +0100 Message-Id: <20201027135509.388981807@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicholas Mc Guire [ Upstream commit 67c3e59443f5fc77be39e2ce0db75fbfa78c7965 ] The call to of_find_compatible_node() returns a node pointer with refcount incremented thus it must be explicitly decremented here before returning. Fixes: a489043f4626 ("powerpc/pseries: Implement arch_get_random_long() based on H_RANDOM") Signed-off-by: Nicholas Mc Guire Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/1530522496-14816-1-git-send-email-hofrat@osadl.org Signed-off-by: Sasha Levin --- arch/powerpc/platforms/pseries/rng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/pseries/rng.c b/arch/powerpc/platforms/pseries/rng.c index bbb97169bf63e..6268545947b83 100644 --- a/arch/powerpc/platforms/pseries/rng.c +++ b/arch/powerpc/platforms/pseries/rng.c @@ -36,6 +36,7 @@ static __init int rng_init(void) ppc_md.get_random_seed = pseries_get_random_long; + of_node_put(dn); return 0; } machine_subsys_initcall(pseries, rng_init); -- 2.25.1