Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp363834pxx; Wed, 28 Oct 2020 06:46:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/KDPj2FgdZHwNAbzgH/+bcna65mfFUv5bKXZ3ZYP3cs1LOA0utXRYmzMtLEJ1JPKZtLNV X-Received: by 2002:a17:906:4351:: with SMTP id z17mr7537613ejm.110.1603892809872; Wed, 28 Oct 2020 06:46:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603892809; cv=none; d=google.com; s=arc-20160816; b=a/7Fo5OhKIywrgva3CQH2Wj21nPe9ZIj8Krlq4sZBU3dFMK6QwLB3yCibTXGv0MvgE /06IkFfZ/hX4j+wHIuHVVLDR2DKw2CzLRWyjMUcxEEUfdpZsC7QG+YSB+2iL05LFwVzZ Qy0OyPCsduLsriFZJnHiFJtAucV/3p/9C3sdBaUCGeZ0Ouk56f9PnAKmX4o4qwA4t+PW cKDBSzend4frDs4SB2sXf6qSBr24x91Zs1N7m2IjkqiCN8WGQ3UPrJy//VU5DpGNKL7b 5zJAS/GhGcjgr/9k7pm5G9FhmVXOOdCY/dBKb7Z8bK8mCwktQQ8h0P+efEQ/RpbwXx9P Cm6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CEY2pujj9o4jjNMKT1pmbVJ2Kvy4Mclirqy45AwoxZU=; b=nAZyEX1r7yI+P2GcDsZdq3mztvkxG9VxBh8EwRvl8F1bkoroz9DaixvjKeWxOa2Fq4 05oOWnZYCATdcJ4e3wpb9TUJ23O477nDWx43JmErNrz+Lvj7zYmHeDHRUZ9gGPYvddiL +Kt3tzG7xoLHpzJ2WxCm7uOPi7zSEVWi3YbhB1ekwL26X2SRtLGQ4zwEnE00Uv91vjH8 PXYhxeJ+e3lLg+VpcETksfkUwBb9EizpE4plJPHJHjPY0oDkt6Fd0LyjLL+StuNddGkC LiEVfqqO5nOD1jUaTQIZ8JMnIRB7FJVfow/lRIGEW4YVhfz6P5ZBuqVdqlJX+y2oqHXX aXqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Eb8hFfN8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p17si2879649ejg.48.2020.10.28.06.46.28; Wed, 28 Oct 2020 06:46:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Eb8hFfN8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1803110AbgJ0PwO (ORCPT + 99 others); Tue, 27 Oct 2020 11:52:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:48548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1799441AbgJ0Pbc (ORCPT ); Tue, 27 Oct 2020 11:31:32 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16C4722265; Tue, 27 Oct 2020 15:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812691; bh=ycDCaRDagqFTzzoaX04Wo1NCnt0iGhVSSvItAJeFy3Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Eb8hFfN8GwmhsXfiCaFezpk6+gsxo8MIV+tnF51I/D+ktVdA2iwZvOcwcGIe4TA4D LcYmJLZFH7x3aUUmoVU7E1b/anT2+FiYVotLfagBUw3yWzQ5He3dGcQ6g/P7EBDl1B oqds7xvbussTADdMyzjEH5cNiXwhxbsVFYep7YJE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Linus Walleij , Florian Fainelli , "David S. Miller" , Sasha Levin Subject: [PATCH 5.9 297/757] net: dsa: rtl8366rb: Support all 4096 VLANs Date: Tue, 27 Oct 2020 14:49:07 +0100 Message-Id: <20201027135504.490870057@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Walleij [ Upstream commit a7920efdd86d8a0d74402dbc80ead03b023294ba ] There is an off-by-one error in rtl8366rb_is_vlan_valid() making VLANs 0..4094 valid while it should be 1..4095. Fix it. Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver") Signed-off-by: Linus Walleij Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/dsa/rtl8366rb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c index 48f1ff7467999..5cfffa7559c7c 100644 --- a/drivers/net/dsa/rtl8366rb.c +++ b/drivers/net/dsa/rtl8366rb.c @@ -1255,7 +1255,7 @@ static bool rtl8366rb_is_vlan_valid(struct realtek_smi *smi, unsigned int vlan) if (smi->vlan4k_enabled) max = RTL8366RB_NUM_VIDS - 1; - if (vlan == 0 || vlan >= max) + if (vlan == 0 || vlan > max) return false; return true; -- 2.25.1