Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp365345pxx; Wed, 28 Oct 2020 06:49:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWs6jTyEbG0yBD87ASdpqMlerzNWf/kjEqQ1FzhFoCqJ5FNfgJu/zwXL5IM9LfAfnPBOZX X-Received: by 2002:a17:906:7c4b:: with SMTP id g11mr7883609ejp.469.1603892941637; Wed, 28 Oct 2020 06:49:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603892941; cv=none; d=google.com; s=arc-20160816; b=n40ycIdKvCBy85znU1CR0KqZrV1A0vDa+1/bDCT61tflLgrODroY0WsJ3e3xdgowcn d8bxTLuGcJ2CV3zkUy9RYINhC52Ceh/uBD/wGVPXQU2q5Y7+fiqXa1RVF+hsJjOObWse tKXukk2LRykdc1xQL+htnj6Z5zDs2+oHa5XBiOCNvyXN1oYLRlYv7FvcYeN4+likzKPs 35/haDHllSyw9/y/c6weRVSGWWGfKKUjIw0xlcgw0BSfjgCYZYcoBZdFIyy6GvVRqILe eCDKB+2M4A6VnzDNzsuMXACLqeT7ratB2BdMOUfMbtDp7MO640gCuFqYYBnuGZWdV6OO 5Pzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LVT4GvaRTIxCUxVg1ptSrIbSYQbAFrE87kzJLUa7Sno=; b=0HcWcxpqt3WxbJxRM3QPAASFSU/BDpYbXLqC/xal88hTPARwf8uyXp5DU3QfDkcxro kx88DrpGDuta3S4tSlQwpzYZOJRfgiPvEsdwTh6d5i3JbpgY/HmMNakTriIYCTcA2s3y 8QfzfcUyT7uTAL4ZrqA+FjVXu2x7EaxS8JYyjNNoBmyOIX0pLkDdqMmBlikMMZi8WuJH vtNZbL4/kFWL+EejJss8+WxXeHdba5xQ2epWijlFB0wOcaw1pSpRjUy7Fjt0RGXiwCtP GKEsjZolualGfQVerilgOmUIIqdsBo++j+IcO7nMm9dqMXbr81DCD3AOBWPYZ3epkWxW qfXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mG9jIn0t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s18si2795558ejd.147.2020.10.28.06.48.38; Wed, 28 Oct 2020 06:49:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mG9jIn0t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1803128AbgJ0PwS (ORCPT + 99 others); Tue, 27 Oct 2020 11:52:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:57470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1801060AbgJ0PiM (ORCPT ); Tue, 27 Oct 2020 11:38:12 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6FCA7204EF; Tue, 27 Oct 2020 15:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603813092; bh=0auaerKuobQ6cxNQMJurEJDWbQL5LCznl5dYZkjYCzA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mG9jIn0tFycoAkpBkX9AE+P3bZE7qtrNfDXWWIFekNW7Gz0fI/LTtcMgR0bH8jOz9 ltQkLFnXZMsgHa61jKgMhfLtsSaGyAPsVIqlTPOAzYkmyGNyEMb6XFpXmGliS/IOOc U3RxQqSHc1nol0hoPYqtQW1YDr0V6y55T+Id76lI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michal Kalderon , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.9 434/757] RDMA/qedr: Fix qp structure memory leak Date: Tue, 27 Oct 2020 14:51:24 +0100 Message-Id: <20201027135510.915238963@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Kalderon [ Upstream commit 098e345a1a8faaad6e4e54d138773466cecc45d4 ] The qedr_qp structure wasn't freed when the protocol was RoCE. kmemleak output when running basic RoCE scenario. unreferenced object 0xffff927ad7e22c00 (size 1024): comm "ib_send_bw", pid 7082, jiffies 4384133693 (age 274.698s) hex dump (first 32 bytes): 00 b0 cd a2 79 92 ff ff 00 3f a1 a2 79 92 ff ff ....y....?..y... 00 ee 5c dd 80 92 ff ff 00 f6 5c dd 80 92 ff ff ..\.......\..... backtrace: [<00000000b2ba0f35>] qedr_create_qp+0xb3/0x6c0 [qedr] [<00000000e85a43dd>] ib_uverbs_handler_UVERBS_METHOD_QP_CREATE+0x555/0xad0 [ib_uverbs] [<00000000fee4d029>] ib_uverbs_cmd_verbs+0xa5a/0xb80 [ib_uverbs] [<000000005d622660>] ib_uverbs_ioctl+0xa4/0x110 [ib_uverbs] [<00000000eb4cdc71>] ksys_ioctl+0x87/0xc0 [<00000000abe6b23a>] __x64_sys_ioctl+0x16/0x20 [<0000000046e7cef4>] do_syscall_64+0x4d/0x90 [<00000000c6948f76>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Fixes: 1212767e23bb ("qedr: Add wrapping generic structure for qpidr and adjust idr routines.") Link: https://lore.kernel.org/r/20200902165741.8355-2-michal.kalderon@marvell.com Signed-off-by: Michal Kalderon Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/qedr/verbs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c index 9141a77534c7d..ae22bb8fe19b8 100644 --- a/drivers/infiniband/hw/qedr/verbs.c +++ b/drivers/infiniband/hw/qedr/verbs.c @@ -2753,6 +2753,8 @@ int qedr_destroy_qp(struct ib_qp *ibqp, struct ib_udata *udata) if (rdma_protocol_iwarp(&dev->ibdev, 1)) qedr_iw_qp_rem_ref(&qp->ibqp); + else + kfree(qp); return 0; } -- 2.25.1