Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp382681pxx; Wed, 28 Oct 2020 07:09:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzl3Jk+L8fzW5ZPIi4QvvJzpXrpUD1pGXHBQuz15YmlI8rJZXRaaNiCtsCuZqasVAyADKsb X-Received: by 2002:a50:f156:: with SMTP id z22mr8033223edl.94.1603894170900; Wed, 28 Oct 2020 07:09:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603894170; cv=none; d=google.com; s=arc-20160816; b=N7i7ryor/CcLiIUdYw7bpW6NPnqxrxcwV2zzlTHGt/o7bPe5qDzNJ8TwhCOaeTcla2 lVfaxJFHaG+lclu0nPAyCPNfIcUQta4fRXd6hW+R4v98taMhZtVQ/L+5wzJ8Ebr9kNv6 MtrFSgkxczRX0JDtmmIIexefzsaDajgSnpof/CVXMUSJZxZdufSSSXwilsTzJM/Y6lo3 AGKr2ePS67fGsHi7R2qxE6ErHu+blX6HIch8Ki8vDFIOf9k5M0iSnuDPoE4XsaFHAphq v4jYuHBNlyH/0PeoKCeFUXf9/lnZaWROogw7e6vXWQjETxLof/P8ICiGLpBbAhvIwthA 0bwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NqB40DYU4vWJIcjaSK5fD+5iqduhQ5asVwA2iwKAI70=; b=zHI+8lniBFflqPlMdybuqY5/XskVXR3BAA5vNgzg0ypxp23mcIZSzXFy2HA6PvSvWo a2W8KLzdyspKsu2hk5TiMDC4NVVdlaN0iuwLv4v8wwOJ5ig6yEI+zTA79uOyG6SQxJ5X jHwpZCfmiGaSDCojaLRAmuixdVUMlCh4XZmBidbkDikBbk8c1ioC+YUVbcO2br4saR4q Y9XrO+tWGzijemnnSnHuJX9EabQa2I2s5DPUc1gX54/MjOctkWDKtWmuEUKgMAsXXHUs cAwclhLsT/x03zxj+8GXfw2JgyFqbRfXphyyrt+lqfTxKhUyURib6Z820K2QmOtWT/X5 5Zdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ppk7TAxI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g1si3663191edn.100.2020.10.28.07.09.08; Wed, 28 Oct 2020 07:09:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ppk7TAxI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1799756AbgJ0P5c (ORCPT + 99 others); Tue, 27 Oct 2020 11:57:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:56416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1794941AbgJ0PSw (ORCPT ); Tue, 27 Oct 2020 11:18:52 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4FC882064B; Tue, 27 Oct 2020 15:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603811931; bh=9BM9kMAapkeQfx1UEEjUi2sDNYGdZC3u89yTbh5MjBE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ppk7TAxIhmZQNC5S1C1evv0riJ/tZ4Tl6mqPFONzHCpNJIk3YGaapbgBEJZ5UtxpU 1aPe6sxR9k6sf6h+MJoOca1HDBcNGMecV84XmEOSwDETsAnsHw62V95pao93rugZpp eAJpvolOczKQwpBkRuMT0P+oXpw6LJ2fjEIYgzIY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Venkatesh Ellapu , Vinay Kumar Yadav , Jakub Kicinski Subject: [PATCH 5.9 033/757] chelsio/chtls: fix panic when server is on ipv6 Date: Tue, 27 Oct 2020 14:44:43 +0100 Message-Id: <20201027135452.079270485@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vinay Kumar Yadav [ Upstream commit 86cdf9ca4409d997a391103e480b3f77b7ccc19b ] Netdev is filled in egress_dev when connection is established, If connection is closed before establishment, then egress_dev is NULL, Fix it using ip_dev_find() rather then extracting from egress_dev. Fixes: 6abde0b24122 ("crypto/chtls: IPv6 support for inline TLS") Signed-off-by: Venkatesh Ellapu Signed-off-by: Vinay Kumar Yadav Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/chelsio/chtls/chtls_cm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/drivers/crypto/chelsio/chtls/chtls_cm.c +++ b/drivers/crypto/chelsio/chtls/chtls_cm.c @@ -736,14 +736,13 @@ void chtls_listen_stop(struct chtls_dev #if IS_ENABLED(CONFIG_IPV6) if (sk->sk_family == PF_INET6) { - struct chtls_sock *csk; + struct net_device *ndev = chtls_find_netdev(cdev, sk); int addr_type = 0; - csk = rcu_dereference_sk_user_data(sk); addr_type = ipv6_addr_type((const struct in6_addr *) &sk->sk_v6_rcv_saddr); if (addr_type != IPV6_ADDR_ANY) - cxgb4_clip_release(csk->egress_dev, (const u32 *) + cxgb4_clip_release(ndev, (const u32 *) &sk->sk_v6_rcv_saddr, 1); } #endif