Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp384914pxx; Wed, 28 Oct 2020 07:12:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtD2Zd4yw1FGhdmjs68TX0e6YhDROFDEIXoy3qLm1qf52fsUDaeESToP0QIJWIR6qbe3Qw X-Received: by 2002:a17:906:b03:: with SMTP id u3mr1775692ejg.3.1603894323045; Wed, 28 Oct 2020 07:12:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603894323; cv=none; d=google.com; s=arc-20160816; b=Ci8LPy9LCY2sN+nlEDIRSMmu0SWxpMqwC1epk5KO6flhGcGuDMT0t3Ry1sReoqGhr2 liJNxPUsnT0opBsdafxZDHPBC0vNxgrULk92LYjAIDqx4x6X4KVlIim+USL/Er//GBfq /yhL/sD69gxsOfJf8VYwkIph1XyzlhBl5IGvyM+HjqhHkZkCD+Pq20h5Nto6zIeuS3Gi SfZ8P5ahgC9rA8xiK6gkp1piVql6YURI7LKKur01BbnaDWm//icDEPFxp6zVHKPyBan9 DzsHVbPxbxOBXui/67akVAaOere8snT/u39Vcs5L36xtoHcSTeOHz18NRREorEZu43Ax BYbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6yPQEiwED2bno4Pis0AAzr37UocumWXuy/T9OBCrjkQ=; b=XWkHPSqEKwEiRdTcBKT9/fg8UjBF0HsqBgxF8+q0L4FMJhIml3l/RLtDohxYgPLEjz pBmlNNJ0E0gFwXuDrtbfisnfBQr53RDRPUahMhXOav11WR6jIXv0Gt+eSSCKUZPSRUYD eO2hiYjtz47nWOqcjw9l2UDTTkpyarAr6BIR4hFIeQurMboYsr+abRjLR+e2TQfPOHwe PApkRoefEK8vXEzOBJyIjwkbHQWIuilci+q1Uv/t029gB/dq/kfdZHH0Adf9AwWy2/x3 FW+hTabpw69d+jW5fT64IBdrntl+eweYNuE19JhlrAZmv95m7zLJazzWKsaOmbFeC8vp JoKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tJDkA8XM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk22si2709939edb.258.2020.10.28.07.11.40; Wed, 28 Oct 2020 07:12:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tJDkA8XM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1801047AbgJ0P5o (ORCPT + 99 others); Tue, 27 Oct 2020 11:57:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:56052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1796444AbgJ0PSl (ORCPT ); Tue, 27 Oct 2020 11:18:41 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 008922064B; Tue, 27 Oct 2020 15:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603811920; bh=GDDgLjCvdP9hJNwmJ1F7bl4nLQrkpUorMjVj4T51kKk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tJDkA8XM1XOrgUu8bs6gmYQ/NdQ6TwIJNXACY3wtz+7c9ACRATv7EvI+B+KGqLiAo rr1oGBH8HJnGKLo5VrSnd3pdyfwAgAKWTULEeqYKvq7vfGUCHkCPsc6M9oUTB/iatV T5zIqFU/86aZGOOtp0vLKNQ0HQijS5LsLjuy+gJw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jon Maloy , Hoang Huu Le , Jakub Kicinski Subject: [PATCH 5.9 029/757] tipc: re-configure queue limit for broadcast link Date: Tue, 27 Oct 2020 14:44:39 +0100 Message-Id: <20201027135451.891158496@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hoang Huu Le [ Upstream commit 75cee397ae6f1020fbb75db90aa22a51bc3318ac ] The queue limit of the broadcast link is being calculated base on initial MTU. However, when MTU value changed (e.g manual changing MTU on NIC device, MTU negotiation etc.,) we do not re-calculate queue limit. This gives throughput does not reflect with the change. So fix it by calling the function to re-calculate queue limit of the broadcast link. Acked-by: Jon Maloy Signed-off-by: Hoang Huu Le Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/tipc/bcast.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/net/tipc/bcast.c +++ b/net/tipc/bcast.c @@ -108,6 +108,7 @@ static void tipc_bcbase_select_primary(s { struct tipc_bc_base *bb = tipc_bc_base(net); int all_dests = tipc_link_bc_peers(bb->link); + int max_win = tipc_link_max_win(bb->link); int i, mtu, prim; bb->primary_bearer = INVALID_BEARER_ID; @@ -121,8 +122,11 @@ static void tipc_bcbase_select_primary(s continue; mtu = tipc_bearer_mtu(net, i); - if (mtu < tipc_link_mtu(bb->link)) + if (mtu < tipc_link_mtu(bb->link)) { tipc_link_set_mtu(bb->link, mtu); + tipc_link_set_queue_limits(bb->link, max_win, + max_win); + } bb->bcast_support &= tipc_bearer_bcast_support(net, i); if (bb->dests[i] < all_dests) continue;