Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp390253pxx; Wed, 28 Oct 2020 07:18:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjBX4e8CC8MZimAZdAVrF6ugmp2TWPHv74FBqk8ocdoSVKW8+xj1M/ty7tr+z8nwOW5jwj X-Received: by 2002:a17:906:444:: with SMTP id e4mr8271188eja.218.1603894701418; Wed, 28 Oct 2020 07:18:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603894701; cv=none; d=google.com; s=arc-20160816; b=Y7PdnV2tnejfuqdLXrgVlA2DFkcSPok+JIHa5k3hEEBRyQbjX2ua387q04ayFdpgsE UDNboRIANT1SGKUxnLFvHRShusSeupLuVGCAdByT6mFWvT9kS4/qtjbiSbPLuF1kmYWa EDTpQ8/fLj/bH8miAMU6jtLYT5Oc8e/zvW/dehgp7c0uUmA0/B8RK/nurzXcWlTHgVDq FxyGFpIrF7nDZ9MO8F8fK7QFbZ0p0RDwmV/1PvRxQ49exMkL8lHphQHtPmD0NcUpEafX /6t+thfmwfL1LLdVbkaUVoOjayMbw3KNxMRC88Yy/WVhPv/AsdmwgoQqYnkBY8su4bi0 baaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sZ2b83sLgmYWDNHvMQxx15fvcdGYlSPtVRvNV0+m3OY=; b=j1lnJPm/4gaofFqi6x+Ow8IPT+CrB7AYg4pB2LbXAgekAhCYsihrJ3fih9+tCLSFRU k4KY1QFtkFvGqs7JavIvqUV4//nfbOX6rXlJEbllLunGHM5v2ryiqbS+nTKANq3hLC/G SvF8YbwzeGgR8eB+cg00hUG5DB4kFGPNM4N7NaBh4XlHzd26en8XMJcAw0Yo5kxcVIXp /KNv2kjknDnw5mFom+ztkoBe7va/fzXDR7HoGsI46EzxEYGAoMow7xInmumXoqpuTYqN JbwhSOc20ln4BJyQnQko/pXvgqKHZz7v5+hptLrFHRefGl7UT4PrpmwiA0doQmULfznD nRWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Jd45dSy4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x26si2664388eds.99.2020.10.28.07.17.59; Wed, 28 Oct 2020 07:18:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Jd45dSy4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1805129AbgJ0QAe (ORCPT + 99 others); Tue, 27 Oct 2020 12:00:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:59306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1801320AbgJ0Pjt (ORCPT ); Tue, 27 Oct 2020 11:39:49 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 841B5222C8; Tue, 27 Oct 2020 15:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603813189; bh=NwfI32U4XMLizAaza+fOHW+41zVNEERjTbx3CXS/e58=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jd45dSy4r9/IWONBVOMUtOY7vIeuPf4xrXy3okU90wFHc40lYIsMiAGzB0yQaWufG pFDXcuB4MGsbBjQ/qL7UNUKanRiefTUhQtE2Ut3OwdQHisRaUb9so7Emc65B0XBIqs CbtFTCqmlJSP1IDxVFMm+cfH+quN9X3BIKGvl/A8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenpeng Liang , Weihang Li , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.9 467/757] RDMA/hns: Fix the wrong value of rnr_retry when querying qp Date: Tue, 27 Oct 2020 14:51:57 +0100 Message-Id: <20201027135512.430173933@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenpeng Liang [ Upstream commit 99fcf82521d91468ee6115a3c253aa032dc63cbc ] The rnr_retry returned to the user is not correct, it should be got from another fields in QPC. Fixes: bfe860351e31 ("RDMA/hns: Fix cast from or to restricted __le32 for driver") Link: https://lore.kernel.org/r/1600509802-44382-7-git-send-email-liweihang@huawei.com Signed-off-by: Wenpeng Liang Signed-off-by: Weihang Li Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c index 547f8c7dcf561..9eaed58fbaee0 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c @@ -4767,7 +4767,9 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr, qp_attr->retry_cnt = roce_get_field(context.byte_212_lsn, V2_QPC_BYTE_212_RETRY_CNT_M, V2_QPC_BYTE_212_RETRY_CNT_S); - qp_attr->rnr_retry = le32_to_cpu(context.rq_rnr_timer); + qp_attr->rnr_retry = roce_get_field(context.byte_244_rnr_rxack, + V2_QPC_BYTE_244_RNR_CNT_M, + V2_QPC_BYTE_244_RNR_CNT_S); done: qp_attr->cur_qp_state = qp_attr->qp_state; -- 2.25.1