Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp432355pxx; Wed, 28 Oct 2020 08:13:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOlDl5V+Y27RTgOQVt6Ft+/r/Z6jKdHKPBCpA0NnVYxYtI9TzOiPwlobTkUviGRQ/AVkrl X-Received: by 2002:a17:906:a981:: with SMTP id jr1mr7698336ejb.99.1603898000844; Wed, 28 Oct 2020 08:13:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603898000; cv=none; d=google.com; s=arc-20160816; b=be8j5ITYq1fiLHQOctW143z8OmqI/lHP4HUXLrUxXhO4D7zqg0r8w9WGDL2jkRf2TS inez5QP6GEe3dPl3Mgv9TIuLywvdrsAc4l7MDfveqtChJZObTaxSoeyU2CuFo1uaMQp9 zz4OlPLinhOmLKhI27vYUrAPBrfDR5aOVmlphgrPLm5+lu4yZoaYd7u+CAa2L1Vzkkte UuNTVwZ9eH4JT2xV31EzoQyqsk8upCyIaYBzYBSyAMW0zXWA2paviut6IrBjXwry/JCP HrFwsM0DshgSwXpxrawCN7iWVDvdxAo3eVF8jPSo4sPSfDoimimq3hKkV1k/ze6GFuuQ oQEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3Fx6L6/Kre1Eoc9+oLnr2thYmdBmEiWMgyxTRqrBqKk=; b=0bGO8tq2BAVF59tJZW15iRXcewCkr5wezzWxprAGxZ7TGEEDHDYqL86CePEDcVVFkd xfBHNWj3KIMn8o6zRb08NwYP3wDvRmGucTl8mGppQ9uBZMD3pumu31xrbzlybcMjTACA DKpkupiY4/vUNHh5rdiU6mQT0dX5qJuxeuGEeCcj/tlfU5dwdxXBnHNgu90gRlW+pc31 L+yIGYJ0fx9c69huHU6X4XcIhiFP8sZndpSu60A1zEkR5w1xTRUNngAUC34jMbahp6aK UbKlIyP8GlK6GHkgdv+4Ye+0a+2261mNTruefNOEOzo/9Ng2i3q7Iw4lOibO7XQnK4fx Qaxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aNZII14H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs17si3022913ejb.543.2020.10.28.08.12.57; Wed, 28 Oct 2020 08:13:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aNZII14H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764050AbgJ0QbS (ORCPT + 99 others); Tue, 27 Oct 2020 12:31:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:51862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1802599AbgJ0Pu1 (ORCPT ); Tue, 27 Oct 2020 11:50:27 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4602D204EF; Tue, 27 Oct 2020 15:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603813827; bh=A37e4dVHhc52u326Jau40fDQWp8Wy/f8qd4T3PclcYc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aNZII14HDk0HqUwNumeBmFm3bO88QbchI4Exz01mh9IVfAov9qcNh2w3IGY6MuECA Lh7dL3LIj90gIhK/enheF3zD0sJT3U/E30FpAPJFhV3SZdZO9dL3i5S/vXkIqu1S4H /m4e3qBGYkxqkRf29oBiHY7LqX9FenY2/h4KdA84= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?J=C3=A9r=C3=B4me=20Pouiller?= , Sasha Levin Subject: [PATCH 5.9 676/757] staging: wfx: fix handling of MMIC error Date: Tue, 27 Oct 2020 14:55:26 +0100 Message-Id: <20201027135522.244534084@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jérôme Pouiller [ Upstream commit 8d350c14ee5eb62ecd40b0991248bfbce511954d ] As expected, when the device detect a MMIC error, it returns a specific status. However, it also strip IV from the frame (don't ask me why). So, with the current code, mac80211 detects a corrupted frame and it drops it before it handle the MMIC error. The expected behavior would be to detect MMIC error then to renegotiate the EAP session. So, this patch correctly informs mac80211 that IV is not available. So, mac80211 correctly takes into account the MMIC error. Signed-off-by: Jérôme Pouiller Link: https://lore.kernel.org/r/20201007101943.749898-2-Jerome.Pouiller@silabs.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/wfx/data_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/data_rx.c b/drivers/staging/wfx/data_rx.c index 33b715b7b94bb..ef0cc1e474ae6 100644 --- a/drivers/staging/wfx/data_rx.c +++ b/drivers/staging/wfx/data_rx.c @@ -44,7 +44,7 @@ void wfx_rx_cb(struct wfx_vif *wvif, memset(hdr, 0, sizeof(*hdr)); if (arg->status == HIF_STATUS_RX_FAIL_MIC) - hdr->flag |= RX_FLAG_MMIC_ERROR; + hdr->flag |= RX_FLAG_MMIC_ERROR | RX_FLAG_IV_STRIPPED; else if (arg->status) goto drop; -- 2.25.1