Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp437216pxx; Wed, 28 Oct 2020 08:19:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzp0wACrzsYrn6Z2rerkeNx54PWHcmVRseVOLtxoYl4wdQnbo5dKagLAlAEqU6vmDKUqNDX X-Received: by 2002:aa7:c6cd:: with SMTP id b13mr8635638eds.32.1603898366306; Wed, 28 Oct 2020 08:19:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603898366; cv=none; d=google.com; s=arc-20160816; b=nmiw2Eob/PShrsiZgCn6cNspnZ38Y++xKF/V0cg/aAIHg9pK0uoNAynqb6UZEwohVl UVMrSgKi/AeM2ZO/4SeUMt/35sFMcpU0quTXiGXkuxm9w+CxT4RWxmG3NG0N0OSpq6Jt SLhuVSnwcIsgzTX6FGAl4IaACsIzm8EGBoJioE63XLFeAwFsjy/PvRPi/cSeXZeUYwjR yoLmQYaql6uVQpdU71jM/Z8+tluuV1quEIsjdPZbSquWdNh0/Z6kx3wCLF6vQzKA9Iew W0aqPVhs4yLkNr3hJ/yf3yYxeC2KqrPbCMQgfNldqm6s2/0h8X725gsZclmBW1GD6uQM Nj0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LXV/1MQoQKMSzjrmn/TZbHn1vsxeJHsZzKzMIhuSu2I=; b=BP2zoAvWBVTMVkil/AIA49zKT/Td/1rn5MOWjUr7bXQyG3WWRkNysMucrxH5oTqnKt wTaZX3p9v2L12IUXdCEjX4N8ybcRg4G0CYtgnZ58o70yDswBmFi1ZUAeWDYeXfouItVB dAaVSsdyCTdMEumm7iom38MsVNHO5LO39Gr0JSsEviLFl8OQ9sAbPIT6DxH7DS7wJ7Zf 63rSK9xvtvfVDpkHHZIae9qKNUkhCp6/lDp4ipCSgdL6kpCNaM1vW4aV2X685wcLaSJ+ KgY0crDLP2fbTml8bVCB94zXOxUPY9OPljd/egRKgCzerpIpJXd2FHyC1VKwMOjAc0fI HNUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0FyunMEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gf17si2900638ejb.226.2020.10.28.08.19.04; Wed, 28 Oct 2020 08:19:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0FyunMEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1810074AbgJ0Qd3 (ORCPT + 99 others); Tue, 27 Oct 2020 12:33:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:50252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2441359AbgJ0PtS (ORCPT ); Tue, 27 Oct 2020 11:49:18 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7A8C9223B0; Tue, 27 Oct 2020 15:49:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603813758; bh=nDTdg9vkigXJJd1FTB/cHEAatr2cCXwcOARRfxBsD1c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0FyunMEY6zxOnGPf2RptLfvRdc/eaa6Cj1iipVu+IkqNkLAhQg00SYOd9a/1LRhIy YJYAtUZBe0ezhX6SHUzDG1zFyPMAqZ+X27sTIntoJMbhCaDqGjohbCsD7MD9GsSBKN Sl47XNOVyCeEluIUaCXjcxMQNMjgKPxIw+E6kbIk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Brad Bishop , Eddie James , Joel Stanley , Mark Brown , Sasha Levin Subject: [PATCH 5.9 661/757] spi: fsi: Fix clock running too fast Date: Tue, 27 Oct 2020 14:55:11 +0100 Message-Id: <20201027135521.543409402@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Brad Bishop [ Upstream commit 0b546bbe9474ff23e6843916ad6d567f703b2396 ] Use a clock divider tuned to a 200MHz FSI bus frequency (the maximum). Use of the previous divider at 200MHz results in corrupt data from endpoint devices. Ideally the clock divider would be calculated from the FSI clock, but that would require some significant work on the FSI driver. With FSI frequencies slower than 200MHz, the SPI clock will simply run slower, but safely. Signed-off-by: Brad Bishop Signed-off-by: Eddie James Signed-off-by: Joel Stanley Link: https://lore.kernel.org/r/20200909222857.28653-3-eajames@linux.ibm.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-fsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsi.c b/drivers/spi/spi-fsi.c index ef5e0826a53c3..a702e9d7d68c0 100644 --- a/drivers/spi/spi-fsi.c +++ b/drivers/spi/spi-fsi.c @@ -403,7 +403,7 @@ static int fsi_spi_transfer_init(struct fsi_spi *ctx) u64 status = 0ULL; u64 wanted_clock_cfg = SPI_FSI_CLOCK_CFG_ECC_DISABLE | SPI_FSI_CLOCK_CFG_SCK_NO_DEL | - FIELD_PREP(SPI_FSI_CLOCK_CFG_SCK_DIV, 4); + FIELD_PREP(SPI_FSI_CLOCK_CFG_SCK_DIV, 19); end = jiffies + msecs_to_jiffies(SPI_FSI_INIT_TIMEOUT_MS); do { -- 2.25.1