Subject: Re: [RHEL5 PATCH 2/2] NFS: Represent 64-bit fileids as 64-bit
	inode numbers on 32-bit systems [try #2]
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, aviro@redhat.com,
       linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
       nfsv4@linux-nfs.org
In-Reply-To: <20060815152632.29222.66333.stgit@warthog.cambridge.redhat.com>
References: <20060815152627.29222.71414.stgit@warthog.cambridge.redhat.com>
	 <20060815152632.29222.66333.stgit@warthog.cambridge.redhat.com>
Content-Type: text/plain
Date: Tue, 15 Aug 2006 12:28:30 -0400
Message-Id: <1155659311.5657.2.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 773
Lines: 23

On Tue, 2006-08-15 at 16:26 +0100, David Howells wrote:
>  
> -		/* We set i_ino for the few things that still rely on it,
> -		 * such as stat(2) */
> -		inode->i_ino = hash;
> +		/* We set i_ino for the few things that still rely on it, such
> +		 * as printing messages; stat and filldir use the fileid
> +		 * directly since i_ino may not be large enough */
> +		inode->i_ino = fattr->fileid;

Are there any plans to remove inode->i_ino? It would appear to have
outlived its usefulness.

Otherwise Acked...

Cheers,
  Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/