Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: TkVPNnlHh87Qmna1IG0JUXndEZBmXEqMKIKmwG11ESwyskO78nt8bIkvsd1qQqB+YjwM//nYaq
 29qBgTDmcDzg==
IronPort-SDR: HXsMrvAkjPUr8QiYpDno6fpZ8tfqF1mxLHLXQH6Xn3teK+iOteaHRF5Fr8kcllVbacPe5rOquO
 BlWKPwfFKDNw==
Subject: Re: [PATCH v3 40/56] firmware: stratix10-svc: fix kernel-doc markups
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>
Cc:     Jonathan Corbet <corbet@lwn.net>, linux-kernel@vger.kernel.org
References: <cover.1603469755.git.mchehab+huawei@kernel.org>
 <f417f0605346b2d72b1a7f5b3989c9aca29729df.1603469755.git.mchehab+huawei@kernel.org>
From:   Richard Gong <richard.gong@linux.intel.com>
Message-ID: <42c3c7bf-bbdb-cba8-af58-37fb3637f443@linux.intel.com>
Date:   Tue, 27 Oct 2020 12:31:12 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <f417f0605346b2d72b1a7f5b3989c9aca29729df.1603469755.git.mchehab+huawei@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Acked-by: Richard Gong <richard.gong@linux.intel.com>

On 10/23/20 11:33 AM, Mauro Carvalho Chehab wrote:
> There are some common comments marked, instead, with kernel-doc
> notation, which won't work.
> 
> While here, rename an identifier, in order to match the
> function prototype below kernel-doc markup.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>   include/linux/firmware/intel/stratix10-svc-client.h | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h
> index a93d85932eb9..ebc295647581 100644
> --- a/include/linux/firmware/intel/stratix10-svc-client.h
> +++ b/include/linux/firmware/intel/stratix10-svc-client.h
> @@ -6,7 +6,7 @@
>   #ifndef __STRATIX10_SVC_CLIENT_H
>   #define __STRATIX10_SVC_CLIENT_H
>   
> -/**
> +/*
>    * Service layer driver supports client names
>    *
>    * fpga: for FPGA configuration
> @@ -15,7 +15,7 @@
>   #define SVC_CLIENT_FPGA			"fpga"
>   #define SVC_CLIENT_RSU			"rsu"
>   
> -/**
> +/*
>    * Status of the sent command, in bit number
>    *
>    * SVC_STATUS_OK:
> @@ -50,7 +50,7 @@
>   #define SVC_STATUS_ERROR		5
>   #define SVC_STATUS_NO_SUPPORT		6
>   
> -/**
> +/*
>    * Flag bit for COMMAND_RECONFIG
>    *
>    * COMMAND_RECONFIG_FLAG_PARTIAL:
> @@ -58,7 +58,7 @@
>    */
>   #define COMMAND_RECONFIG_FLAG_PARTIAL	1
>   
> -/**
> +/*
>    * Timeout settings for service clients:
>    * timeout value used in Stratix10 FPGA manager driver.
>    * timeout value used in RSU driver
> @@ -218,7 +218,7 @@ void stratix10_svc_free_memory(struct stratix10_svc_chan *chan, void *kaddr);
>   int stratix10_svc_send(struct stratix10_svc_chan *chan, void *msg);
>   
>   /**
> - * intel_svc_done() - complete service request
> + * stratix10_svc_done() - complete service request
>    * @chan: service channel assigned to the client
>    *
>    * This function is used by service client to inform service layer that
>