Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp530308pxx; Wed, 28 Oct 2020 10:23:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhGQox22qxbNMa55xbWE5759UVhomDb2TkdTcyOpFSZZanI4Hp4yCmvPcwznoqrcMzTPAj X-Received: by 2002:aa7:ce8d:: with SMTP id y13mr2476591edv.65.1603905823816; Wed, 28 Oct 2020 10:23:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603905823; cv=none; d=google.com; s=arc-20160816; b=N5f8KoSrLgn+SfB55EJznXNbDN/PLLE/MrhkDwCJ3/eiYUDT4DMizgmpku4jyvtE7m p2Kz+Zmr7hrrrhAwzAivgfT6sNirV8fBNGWz2C6Gw4IpyGN1TaaISVTY0g5idaUl5GPJ KWf4LzrfxjTsaFzNEcCak2BFiWHV0LeyXG4jjqnNFjKIoo/qT8mafd4U2eDmzraarcgW 8JxddrQVkTcFDzjK/UJS2E0Csi/CXr50D+Qp6aLhrHKeKy1EJV9fUI5Sl26k67MN9Bmh zSUIp+t09xLin4FsT/ANxAIPzomSEuwLdWL8Vg+zx6Jmc5gkUwx2ykACR7d2KVEOyzJ2 dneg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3dMptE0YKbD4pjJwHRXjbOUbIwl0M8aCQ5XvYR+BsNQ=; b=HLCP+5TLQUcFKjrs45X13+0Ah3yIM5tYhSm/qLyy+TcBwu0wEjmOmKS85yDbHmfoDE dK7xVT/yBVqqlNOHQLi1+e+Xzx+zfwcE4r9bHnkXDUflP0ZHKnper+uSZ173DwgRdwpU phW9m6DaF4X3PnkwdJ//UAKCkoy3cd+g7sKXL+Db1e1f/A5bGm/YulZA9Iu7qn1pyKfh k6mREKO1d37Vt+QojnHatMqPgj5y3T5Fwc7nG8lotAWJi5FkbcP/Gu34zmYgUHKT1wQB bMZSFRHhn6S3pY3d6qTe+vmwLkOU1plE4CeWDSF1ze3rZ8mWcki/lSiBpBNa9AkZ2nMK gzAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NAq7KZZV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ay1si32292edb.3.2020.10.28.10.23.20; Wed, 28 Oct 2020 10:23:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NAq7KZZV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1821199AbgJ0RlO (ORCPT + 99 others); Tue, 27 Oct 2020 13:41:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:59600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2902323AbgJ0Oco (ORCPT ); Tue, 27 Oct 2020 10:32:44 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF7AF20709; Tue, 27 Oct 2020 14:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603809163; bh=mK95Y5EpJLO5QnvBvmW3V/40l56fS/jzkZVuuRNb4VY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NAq7KZZV6x06lNxPFCj4J2OtKSOuE+bFDsbDeW5lpo17HTKGFiCwyBgHhdPdEBqXQ RILrLEodyRmhWZW0gtI885ZLD/4NHjn6GW7PKqYF5vm06rj9hr1gRT6CaOYX7Bb7uj UChFwLzNDXuhKXiN55P6vb53g/lq1M8WaI5dfSGM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Necip Fazil Yildiran , Linus Walleij , Sasha Levin Subject: [PATCH 5.4 099/408] pinctrl: bcm: fix kconfig dependency warning when !GPIOLIB Date: Tue, 27 Oct 2020 14:50:37 +0100 Message-Id: <20201027135459.683252641@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135455.027547757@linuxfoundation.org> References: <20201027135455.027547757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Necip Fazil Yildiran [ Upstream commit 513034d8b089b9a49dab57845aee70e830fe7334 ] When PINCTRL_BCM2835 is enabled and GPIOLIB is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP Depends on [n]: GPIOLIB [=n] Selected by [y]: - PINCTRL_BCM2835 [=y] && PINCTRL [=y] && OF [=y] && (ARCH_BCM2835 [=n] || ARCH_BRCMSTB [=n] || COMPILE_TEST [=y]) The reason is that PINCTRL_BCM2835 selects GPIOLIB_IRQCHIP without depending on or selecting GPIOLIB while GPIOLIB_IRQCHIP is subordinate to GPIOLIB. Honor the kconfig menu hierarchy to remove kconfig dependency warnings. Fixes: 85ae9e512f43 ("pinctrl: bcm2835: switch to GPIOLIB_IRQCHIP") Signed-off-by: Necip Fazil Yildiran Link: https://lore.kernel.org/r/20200914144025.371370-1-fazilyildiran@gmail.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/bcm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/bcm/Kconfig b/drivers/pinctrl/bcm/Kconfig index dcf7df797af75..0ed14de0134cf 100644 --- a/drivers/pinctrl/bcm/Kconfig +++ b/drivers/pinctrl/bcm/Kconfig @@ -23,6 +23,7 @@ config PINCTRL_BCM2835 select PINMUX select PINCONF select GENERIC_PINCONF + select GPIOLIB select GPIOLIB_IRQCHIP default ARCH_BCM2835 || ARCH_BRCMSTB help -- 2.25.1