Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp646853pxx; Wed, 28 Oct 2020 13:19:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjjPXgmVtawBoz5xCUgFMhs+NIHS3+NYaG3qSUrgpSTVMG2w5g2iRSp/XhfAcBqOlC8VU0 X-Received: by 2002:aa7:c98f:: with SMTP id c15mr702450edt.200.1603916340523; Wed, 28 Oct 2020 13:19:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603916340; cv=none; d=google.com; s=arc-20160816; b=bG9/QqMK/Rjdtb7h0XAZ2oob2bSTv7BpScfj+ITDjU0js/W2mvH07sDfsOgXVtgj3g 3fhED4YuGMWKWYQr13ni+GD8peI6Rp4re/f7Iz7TQ7hPOBabdEiOcv/lkjiG11lZ2j8f n6IKUimjxJSeKMkOz5a2KqUfarTPXnX5Q4c7o1gMCd0RgMw/svAk27FiPawzmoeMQnoJ nGv2gcFjmFANmeHWOiKcUZXjK3FIwuw1ekG7NE7pStJ7SamghRYwysG/Vjxnitmt/wzX mnm8lCInSi21dYIP8YGgw6FDqLauNo7WrFm5079jAaPrJab7jWHLiurOvSoC9MnwRG7X tgAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=QkpRpV0HVFOVKMjlpvHXkr9LKn3RHCsIZpfhczrRaTs=; b=DPUH/opFT3Ekgc2NrqW+BHQMTr/iAeniQhx2/SEjPGxLcmHETk5unD4aC8O0Ic5VXL A9jc4+Aqyy4f8uxA/itWu2GPSQSKghsUQTTy08f1RB0bgEqcc2Tb94vmb+uJSDKV+9NE EU/LY/ZL8uX0278tIp26nemcHkfYDBgaJT3myfDdzvGnz/FS7Pd2MlLDrLOU0sS4ikzT RlHmslIxgq9RUqWSuC5/qD95+bx1hOu543IMihTL6y4fI2XCYiHkft9Tzt9kMgLQDO6i rX/Tiaf9pLktmEphLgBx24vh5o4LH7x59jQX173YDofx61KjmnBykzbp4aIfcF6Qbo9J SNXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r21si3290edo.519.2020.10.28.13.18.38; Wed, 28 Oct 2020 13:19:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S371321AbgJ0S72 (ORCPT + 99 others); Tue, 27 Oct 2020 14:59:28 -0400 Received: from mga05.intel.com ([192.55.52.43]:40774 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2901077AbgJ0S71 (ORCPT ); Tue, 27 Oct 2020 14:59:27 -0400 IronPort-SDR: liaQlFBgOCToAWDxOOPOmfwfpOp+OKBafkBziGDKtL3l5JsFJuDL2VpemmfyLLqy96wnAi/h8z 2P848vQCJ1qQ== X-IronPort-AV: E=McAfee;i="6000,8403,9787"; a="252843333" X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="252843333" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 11:59:24 -0700 IronPort-SDR: SFyqsuloCpBFPe0fRFFSk+S/ZWCe/xFa/AgewmFcVG01vyQXYbZBjj8wJdmMZ1FKJRtIfSVo2Z xg1dmHdYpzSA== X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="524844162" Received: from nakabir-mobl.amr.corp.intel.com (HELO [10.212.164.122]) ([10.212.164.122]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 11:59:22 -0700 Subject: Re: [PATCH v9 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Maxime Ripard , Chen-Yu Tsai , Rob Herring , Mark Brown , Liam Girdwood Cc: devicetree@vger.kernel.org, Jernej Skrabec , alsa-devel@alsa-project.org, Samuel Holland , linux-kernel@vger.kernel.org, Takashi Iwai , Marcus Cooper , linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org References: <20201027183149.145165-1-peron.clem@gmail.com> <20201027183149.145165-2-peron.clem@gmail.com> From: Pierre-Louis Bossart Message-ID: <01e34ad3-c695-c6eb-95dd-76c2cda77c6f@linux.intel.com> Date: Tue, 27 Oct 2020 13:58:02 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201027183149.145165-2-peron.clem@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -452,11 +454,11 @@ static int sun8i_i2s_set_chan_cfg(const struct sun4i_i2s *i2s, > case SND_SOC_DAIFMT_DSP_B: > case SND_SOC_DAIFMT_LEFT_J: > case SND_SOC_DAIFMT_RIGHT_J: > - lrck_period = params_physical_width(params) * slots; > + lrck_period = slot_width * slots; > break; > > case SND_SOC_DAIFMT_I2S: > - lrck_period = params_physical_width(params); > + lrck_period = slot_width; > break; Aren't I2S, LEFT_J and RIGHT_J pretty much the same in terms of lrclk rate/period? the only thing that can change is the polarity, no? Not sure why it's handled differently here?