Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <f69575e0-5170-2d51-8d74-8b3453723aa3@kernel.dk> <20201027191920.GA262123@centos.familie-tometzki.de>
In-Reply-To: <20201027191920.GA262123@centos.familie-tometzki.de>
From:   Naresh Kamboju <naresh.kamboju@linaro.org>
Date:   Wed, 28 Oct 2020 00:57:14 +0530
Message-ID: <CA+G9fYs7n-XF0xoWJMUtwdc9p95-_53ZpyQrQ1xEsot1vmwAvQ@mail.gmail.com>
Subject: Re: [PATCH] Fix compat regression in process_vm_rw()
To:     Jens Axboe <axboe@kernel.dk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>, Kyle Huey <me@kylehuey.com>
Cc:     lkft-triage@lists.linaro.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 28 Oct 2020 at 00:49, damian
<damian.tometzki@familie-tometzki.de> wrote:
>
> On Mo, 26. Okt 18:03, Jens Axboe wrote:
> > The removal of compat_process_vm_{readv,writev} didn't change
> > process_vm_rw(), which always assumes it's not doing a compat syscall.
> > Instead of passing in 'false' unconditionally for 'compat', make it
> > conditional on in_compat_syscall().
> >
> > Fixes: c3973b401ef2 ("mm: remove compat_process_vm_{readv,writev}")
> > Reported-by: Kyle Huey <me@kylehuey.com>
> > Signed-off-by: Jens Axboe <axboe@kernel.dk>
> >
> > ---
> >
> > diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c
> > index fd12da80b6f2..05676722d9cd 100644
> > --- a/mm/process_vm_access.c
> > +++ b/mm/process_vm_access.c
> > @@ -273,7 +273,8 @@ static ssize_t process_vm_rw(pid_t pid,
> >               return rc;
> >       if (!iov_iter_count(&iter))
> >               goto free_iov_l;
> > -     iov_r =3D iovec_from_user(rvec, riovcnt, UIO_FASTIOV, iovstack_r,=
 false);
> > +     iov_r =3D iovec_from_user(rvec, riovcnt, UIO_FASTIOV, iovstack_r,
> > +                             in_compat_syscall());
> >       if (IS_ERR(iov_r)) {
> >               rc =3D PTR_ERR(iov_r);
> >               goto free_iov_l;
> >
> > --
> > Jens Axboe
> >
> Hello Jens,
>
> i got the following error when i try to build.
>
> m/process_vm_access.c: In Funktion =C2=BBprocess_vm_rw=C2=AB:
> mm/process_vm_access.c:277:5: Fehler: Implizite Deklaration der Funktion =
=C2=BBin_compat_syscall=C2=AB; meinten Sie =C2=BBin_ia32_syscall=C2=AB? [-W=
error=3Dimplicit-function-declaration]
>   277 |     in_compat_syscall());
>       |     ^~~~~~~~~~~~~~~~~
>       |     in_ia32_syscall
>

I have also noticed this build failure on Linus's mainline master branch.

x86_64 : FAILED
i386: FAILED
arm: FAILED

make -sk KBUILD_BUILD_USER=3DTuxBuild -C/linux -j16 ARCH=3Dx86 HOSTCC=3Dgcc
CC=3D"sccache gcc" O=3Dbuild

50../mm/process_vm_access.c: In function =E2=80=98process_vm_rw=E2=80=99:
51../mm/process_vm_access.c:277:5: error: implicit declaration of
function =E2=80=98in_compat_syscall=E2=80=99; did you mean =E2=80=98in_ia32=
_syscall=E2=80=99?
[-Werror=3Dimplicit-function-declaration]
52 277 | in_compat_syscall());
53 | ^~~~~~~~~~~~~~~~~
54 | in_ia32_syscall
55cc1: some warnings being treated as errors


Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>

full test build log:
https://gitlab.com/Linaro/lkft/mirrors/torvalds/linux-mainline/-/jobs/81520=
2967


--=20
Linaro LKFT
https://lkft.linaro.org