Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp691186pxx; Wed, 28 Oct 2020 14:38:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxu3zOr/Yp7h7mIuWXq9UBi2e2RagSluOF6xDniJ4AgsODsaTGUzEGwSvZU0Ag12pXuviEG X-Received: by 2002:a17:906:5793:: with SMTP id k19mr1138366ejq.410.1603921101987; Wed, 28 Oct 2020 14:38:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603921101; cv=none; d=google.com; s=arc-20160816; b=efj7TryTCuYSTOYQ5uCsX0B1FGSaCAZPuZQRWvClh5NvrPY7XjZDNUEejSZnCMhhX5 KnGffLI+R1U2MiyytW4asKpRFO3zah5cum8t/ivq2J4qJ+6xpx8i8uyLNOYTysgRx5ut ovvsJvoZ68Cg1WVPWtLX0y1DCL9iehyJ6BGA/VHofBd3qX3kfKqfBpqpxExP5ZXMVA3L Q4DFxWh7TMZ97ClI273zpu1Okquyltw6SKf5+bu7uC/O6Jnzo8xzJDMBmni4b/VAHtYx nPgKV71snVBgjaoJsb4jyXI6BFsGue2FIosMYWJOh1GQ5eD+O/1CUydRHVEOZM+z+DFU LrDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=4b6VyQ0HwxDlWbLvbh4dp6SVrQcSG7isjpohL6CKvxs=; b=Kb2KBR/nr2pTQAtsetABM0McT5Udhp5VeGB5OahWxUm1+hjoFJ/bzXOJtFeLrn4cwx l1EElTMT/frwycTuFu/hRqrEuTZo6atRv9fCGnVDbXFITdinacnmvg7foOUbT9dmDSOy 7YCuuI3y14zWjq+mWu+XS56p0wEc4EwHZ27aaxYx844Bu3oiH+hl4eizSL/KubrOG0U5 oMsVMi5Uy35b+omydPYoo6GbD96GfAfZyV3F7gP0RumNabakwsjJcf5qRl6iaT97hXD1 zfPBWNDYtLfg3K8n1gG6uz2K7Fe7Fe/isk4WdeIgUNMTkIjTc+C7f+Fsbyed7Lvwy2Bk 5J2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k2si592256edx.2.2020.10.28.14.38.00; Wed, 28 Oct 2020 14:38:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S374263AbgJ0VnC (ORCPT + 99 others); Tue, 27 Oct 2020 17:43:02 -0400 Received: from mga11.intel.com ([192.55.52.93]:17169 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S374255AbgJ0VnC (ORCPT ); Tue, 27 Oct 2020 17:43:02 -0400 IronPort-SDR: jhBCm9qfTYj7cDTBCGQE3rafoavo71X0dvxRFhcKbDNxMe+TsYQwaY68C78srn84FkhJh55GHJ uZbymX0/fN2g== X-IronPort-AV: E=McAfee;i="6000,8403,9787"; a="164667230" X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="164667230" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 14:43:01 -0700 IronPort-SDR: pBWXmGg2hoMlOZK03fXrXVykvhvHWMqpc14Ocyp6ZoqiswJy47qT2/VV+/ub4fZUz+Jv8muNnH S2Vc9/xB0A9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="334537302" Received: from sjchrist-coffee.jf.intel.com ([10.54.74.160]) by orsmga002.jf.intel.com with ESMTP; 27 Oct 2020 14:43:01 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon Subject: [PATCH 0/3] KVM: x86/mmu: Add macro for hugepage GFN mask Date: Tue, 27 Oct 2020 14:42:57 -0700 Message-Id: <20201027214300.1342-1-sean.j.christopherson@intel.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a macro, which is probably long overdue, to replace open coded variants of "~(KVM_PAGES_PER_HPAGE(level) - 1)". The straw that broke the camel's back is the TDP MMU's round_gfn_for_level(), which goes straight for the optimized approach of using NEG instead of SUB+NOT (gcc uses NEG for both). The use of '-(...)' made me do a double take (more like a quadrupal take) when reading the TDP MMU code as my eyes/brain have been heavily trained to look for the more common '~(... - 1)'. Sean Christopherson (3): KVM: x86/mmu: Add helper macro for computing hugepage GFN mask KVM: x86/mmu: Open code GFN "rounding" in TDP MMU KVM: x86/mmu: Use hugepage GFN mask to compute GFN offset mask arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/mmu/mmu.c | 4 ++-- arch/x86/kvm/mmu/mmutrace.h | 2 +- arch/x86/kvm/mmu/paging_tmpl.h | 4 ++-- arch/x86/kvm/mmu/tdp_iter.c | 11 +++-------- arch/x86/kvm/mmu/tdp_mmu.c | 2 +- arch/x86/kvm/x86.c | 6 +++--- 7 files changed, 13 insertions(+), 17 deletions(-) -- 2.28.0