Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Reply-To: tasleson@redhat.com
Subject: Re: [PATCH] buffer_io_error: Use dev_err_ratelimited
From:   Tony Asleson <tasleson@redhat.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Linux FS Devel <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20201026155730.542020-1-tasleson@redhat.com>
 <CAHp75Vfno9LULSfvwYA+4bEz4kW1Z7c=65HTy-O0fgLrzVA24g@mail.gmail.com>
 <71148b03-d880-8113-bd91-25dadef777c7@redhat.com>
Organization: Red Hat
Message-ID: <ec93ba9e-ead9-f49a-d569-abf4c06a60eb@redhat.com>
Date:   Wed, 28 Oct 2020 16:05:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.1
MIME-Version: 1.0
In-Reply-To: <71148b03-d880-8113-bd91-25dadef777c7@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/28/20 3:45 PM, Tony Asleson wrote:
> On 10/26/20 5:07 PM, Andy Shevchenko wrote:

>>> +       dev_err_ratelimited(gendev,
>>> +               "Buffer I/O error, logical block %llu%s\n",
>>
>>> +               (unsigned long long)bh->b_blocknr, msg);
>>
>> It's a u64 always (via sector_t), do we really need a casting?
> 
> That's a good question, grepping around shows *many* instances of this
> being done.  I do agree that this doesn't seem to be needed, but maybe
> there is a reason why it's done?

According to this:

https://www.kernel.org/doc/html/v5.9/core-api/printk-formats.html

This should be left as it is, because 'sector_t' is dependent on a
config option.

-Tony