Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp708666pxx; Wed, 28 Oct 2020 15:09:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaXHheCEZ1aWfQd5LdY5P/fYo+7dYMkRenoEaJFVQ8xRg7tSKVNnHLhilZgKqPJmB3OaRB X-Received: by 2002:a05:6402:1e9:: with SMTP id i9mr1085757edy.317.1603922950532; Wed, 28 Oct 2020 15:09:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603922950; cv=none; d=google.com; s=arc-20160816; b=Mt/rN7XHd68jK8XsKejoCgVmzszU4KZoge1JPHZp9LL2jBqafd6IVrk1HCrP5tGlUF 0nWeDCntc5bdi0Z9PGs8ARFjakLXMm7JxTA7MfWnkblLUAByHus83E1F1GzEbBCxK1c+ HCBKYkfXXqGWGxYK8dRynAeD/TkSW/uLl3mMVsiYRTEVS6kOw5uL/sWE+8Lck2hiVFoV xdf5RiPKGKdT6xJVGgOIIQU4iMt/VtYWOwD2exsajk1YkbJFO1t/Jx9V7g2nac06fYjE ywxZiQfspzXNaqiKqYj3AOsW1l0BEPjPrjvHMGeUrJjiXM9HEzegmqAjIkARt8jUm+WX PIUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=JxgCDIHkSzG1umtCU1pz64+XvK5Tm0nVN/+RvcdRhw4=; b=LmTZmHsipZvfUkA+jIQIdaISPmpLjgcY300ABZ+UNAFovMrbchRthuIwDhfGhFPqAs 0OECGq87ye5lUfohKdr06CXU0dEPBJId312YKTJEZJgAD/tvIJ1egNcDVNROnCYPt4Zy ayv2XwPFqzNJ+pDEIMNUvsB991UptaOWAUUykISi7Oya9Vy0qz3o6w11d3eWJ9HqJ4ra TGoXBeFLksxMCsjsdfQ0YlpPLXh/sqUZFiJS85B5aPSeXAju84KXpwTvUziQAs69h95v HiOWn+UAIVQ86cyNBTW8NbZuIigwICzx/3S966IZeXf0x0UWRbDjrpehP5MJwy8M6SeO TLcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o5si618175edz.212.2020.10.28.15.08.46; Wed, 28 Oct 2020 15:09:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730081AbgJ1WHW (ORCPT + 99 others); Wed, 28 Oct 2020 18:07:22 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:6567 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730063AbgJ1WHV (ORCPT ); Wed, 28 Oct 2020 18:07:21 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CLjSz03ZgzhbL0; Wed, 28 Oct 2020 17:09:55 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 17:09:44 +0800 From: Qinglang Miao To: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team CC: , , Qinglang Miao Subject: [PATCH] ARM: imx: add missing clk_disable_unprepare() when remove imx_mmdc Date: Wed, 28 Oct 2020 17:15:39 +0800 Message-ID: <20201028091539.136026-1-miaoqinglang@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clock source is prepared and enabled by clk_prepare_enable() in probe function, but no disable or unprepare in remove. Signed-off-by: Qinglang Miao --- arch/arm/mach-imx/mmdc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c index 0dfd0ae7a..56375e8da 100644 --- a/arch/arm/mach-imx/mmdc.c +++ b/arch/arm/mach-imx/mmdc.c @@ -462,6 +462,7 @@ static int imx_mmdc_remove(struct platform_device *pdev) cpuhp_state_remove_instance_nocalls(cpuhp_mmdc_state, &pmu_mmdc->node); perf_pmu_unregister(&pmu_mmdc->pmu); + clk_disable_unprepare(mmdc_ipg_clk); kfree(pmu_mmdc); return 0; } -- 2.23.0