Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp709449pxx; Wed, 28 Oct 2020 15:10:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjmlKWLgbM7Hv+A9XX0nB/jdMMpv0r7IfdpXRS+/QPE5z5h/Z16E/VGP+xJFc91Vzgh9r4 X-Received: by 2002:a17:906:7157:: with SMTP id z23mr1235223ejj.474.1603923027732; Wed, 28 Oct 2020 15:10:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603923027; cv=none; d=google.com; s=arc-20160816; b=qxLzY/ptQKreAKKGUMoRfYxCTgsFL5IpL50C8lWJGiHVDE3OLtejNm+rS28PK3HR3U CLRT/H5dgwFAPJ9OMPPp745Q/LL2W9ZE97dcjfKHLAMLPmjIB5n61pKvuatZZfYScFVu QC4WBqX/RLW2IpYM8X7F3fc5JPCb3qvgd8GaZU4gK5xvZqKG3Wl6je5iJa9CCJSfU6BS YiOX0CMsoXY+Gl5qqz4oYc5qXgZvtiLgNBvVC4khjSup93OuvQOKN1iIwiO9DEzdSKzX 9mZA1f+rjFETrJiXMHTitIcTlRcMHNk0M2AWlvpB2HTNPCVgPqKmCZMIccgUd6zNzdjQ 2DPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=EzIECkLGV+n+oR1Mu5XFUAuED7gGNvUPxIrUkufqycY=; b=gAixKbEoumL5pIVMOU7YK6DpcscLId3ERBmdwLOx3ngGCIaDc+pdyt7TFEakzjLvSz iDXhhuYQbZigLh89jeT8x3GMoYLWCwZW30RfYdoEu5MSs6u2FXeNsnrNPll7YYO/CN9K atCvKmv9IPF2nMT0joYmdEZviD5SGZVMBx/T/at/JLx1mvQ/7n+kGY5yNW8rmWXdvZWx 3dXmRv1xmt1Qp6jRN86NikQEIGC5IqBXoDugjsV15Ccl1jE3kmAXVZHbwLoB7Byi7TK8 zB0+v6j4wY2I5G2RFLe4zoriD8yey6nJRwbXMUgM11pKaBxhC0mBt8s3HUnyFjFVx7Ty Ko+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qk3si479398ejb.700.2020.10.28.15.10.06; Wed, 28 Oct 2020 15:10:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730067AbgJ1WHV (ORCPT + 99 others); Wed, 28 Oct 2020 18:07:21 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:6566 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730062AbgJ1WHV (ORCPT ); Wed, 28 Oct 2020 18:07:21 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CLjTF4MbwzhbTH; Wed, 28 Oct 2020 17:10:09 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 17:09:56 +0800 From: Qinglang Miao To: Greg Kroah-Hartman CC: , , "Qinglang Miao" Subject: [PATCH] staging: ks7010: fix missing destroy_workqueue() on error in ks7010_sdio_probe Date: Wed, 28 Oct 2020 17:15:52 +0800 Message-ID: <20201028091552.136445-1-miaoqinglang@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add the missing destroy_workqueue() before return from ks7010_sdio_probe in the error handling case. Signed-off-by: Qinglang Miao --- drivers/staging/ks7010/ks7010_sdio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index 6b2660c94..af68961dd 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -1029,10 +1029,12 @@ static int ks7010_sdio_probe(struct sdio_func *func, ret = register_netdev(priv->net_dev); if (ret) - goto err_free_netdev; + goto err_destroy_wq; return 0; + err_destroy_wq: + destroy_workqueue(priv->wq); err_free_netdev: free_netdev(netdev); err_release_irq: -- 2.23.0