Message-ID: <20060815195231.17015.qmail@lwn.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drop second arg of unregister_chrdev() 
From: corbet@lwn.net (Jonathan Corbet)
In-reply-to: Your message of "Tue, 15 Aug 2006 07:35:22 +0400."
             <20060815033522.GA5163@martell.zuzino.mipt.ru> 
Date: Tue, 15 Aug 2006 13:52:31 -0600
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 745
Lines: 17

> * "name" is trivially unused.
> * Requirement to pass to unregister function anything but cookie you've
>   got from register counterpart is wrong.

Might this, instead, be an opportunity to get rid of the internal
register_chrdev() and unregister_chrdev() calls in favor of the cdev
interface?  register_chrdev() is a bit of a backward-compatibility hack
at this point, and cdevs, in theory, are safer since they won't present
drivers with minor numbers they might not be prepared to handle.

jon

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/