Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Oct 2020 18:09:33 -0400
From:   Sasha Levin <sashal@kernel.org>
To:     Matthieu Baerts <matthieu.baerts@tessares.net>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Mat Martineau <mathew.j.martineau@linux.intel.com>,
        Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH 5.9 580/757] selftests: mptcp: depends on built-in IPv6
Message-ID: <20201028220933.GC87646@sasha-vm>
References: <20201027135450.497324313@linuxfoundation.org>
 <20201027135517.727716271@linuxfoundation.org>
 <3cdf310c-dcef-ad91-6f30-3cd48c6c47de@tessares.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <3cdf310c-dcef-ad91-6f30-3cd48c6c47de@tessares.net>
Precedence: bulk

On Tue, Oct 27, 2020 at 04:59:45PM +0100, Matthieu Baerts wrote:
>Hi Greg,
>
>On 27/10/2020 14:53, Greg Kroah-Hartman wrote:
>>From: Matthieu Baerts <matthieu.baerts@tessares.net>
>>
>>[ Upstream commit 287d35405989cfe0090e3059f7788dc531879a8d ]
>>
>>Recently, CONFIG_MPTCP_IPV6 no longer selects CONFIG_IPV6. As a
>>consequence, if CONFIG_MPTCP_IPV6=y is added to the kconfig, it will no
>>longer ensure CONFIG_IPV6=y. If it is not enabled, CONFIG_MPTCP_IPV6
>>will stay disabled and selftests will fail.
>
>I think Sasha wanted to drop this patch [1]. But as I said earlier 
>[2], this patch is not wrong, it is just not needed in v5.9 because 
>the "Fixes" commit 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on 
>IPV6 instead of selecting it") is not in v5.9.
>
>I guess it is certainly easier to keep it because it is not wrong and 
>doesn't hurt.

I dropped a wrong patch by accident :(

Fixing this up... Thanks for pointing it out!

-- 
Thanks,
Sasha