Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp721041pxx; Wed, 28 Oct 2020 15:31:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBbpB41VTwrrUGC/ZleDBD4xOeRj2zjDVHewxYIqwWwwVM+XLNFnI5141n1eUGXuiuT2CV X-Received: by 2002:a17:906:c78a:: with SMTP id cw10mr1305700ejb.478.1603924296030; Wed, 28 Oct 2020 15:31:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603924296; cv=none; d=google.com; s=arc-20160816; b=RZtpX7X2PY41UwJ796c9VOyn4SNH9Xw0zxjPlzCA4ZFxkdR6h1YgEONkNRDofb7Cxl DUndBJHGVIRvH/ivipXn9bxFD/MjdIVv5Yk3Ul00KFptmtiuPXT74ZLFcZgo8v6JN1Kd eE2nztKKdBLEqtdOPSoJYTATQs9W7DU5gSeXpol6flc+f2wNdZWQgPdD4tabAoud614V o0Z1zrm9RIqzmx9HmFMRgs6wcKdDlgKVYvMGB4CV4RF7m7BtXJlmoTmlOd8mPmaFfcGW NbFhKzWblW37R+71+yKk8kP/sCP33NDRXgw3GkcinN1Fk1Y0GAoGxIbTG4rjVuw98wJZ hVLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=WLWDWfUn62HuyKL78MLrBuM1P4gEN0IVPMugnmjyIpc=; b=zu/9xhScGlzSC7yTEKB5j9T4fmbMkQmxDTIbIWOQ6aybkihq8XPH3dEPjTu8o1UjHI gCJTVMzCimtZygHEGDT8J5MpdoNY1vdi4Bnixf+5SmRgvTSYXHIcwvLFf3kuIjZBav7y VfTlrukKbb8hDxNsGoevQKJdRil4L5mb8/euvfMgsluGQlDkkLxNT7YYWWpgZee0KlJy NQ5j4Xf2qog2q8VI40LEGQnFwf5nWHxRaeN/C5jQr0DqWDcPGGZCSWfWB105Hx2gLgIs s3ifhfuk7ephDfyUQIHBpsInzPI/ZtAbWlEvC8uJH3ic2uFhnmw31w2opLjL41itETjp RL7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=Oj55s1u+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h5si490984ejy.563.2020.10.28.15.31.14; Wed, 28 Oct 2020 15:31:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=Oj55s1u+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387619AbgJ1W3p (ORCPT + 99 others); Wed, 28 Oct 2020 18:29:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387584AbgJ1W3m (ORCPT ); Wed, 28 Oct 2020 18:29:42 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E32BDC0613CF for ; Wed, 28 Oct 2020 15:29:41 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id h22so755000wmb.0 for ; Wed, 28 Oct 2020 15:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=WLWDWfUn62HuyKL78MLrBuM1P4gEN0IVPMugnmjyIpc=; b=Oj55s1u+HirbuDDCtgGf2TCwNQs1t7Hb/dfEAbtoX4rp6Vi9YOyYi0ZR6vyFEJnv46 srMzjKdpNzPMuK/b/uwsPoV8xLsInM+031sEoA5Uns+jUhqfFFLnA1zctrfKyId7XHGc IbDB6x5ghe+8hsKenVf6Dwci2fYo3m0yskyWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=WLWDWfUn62HuyKL78MLrBuM1P4gEN0IVPMugnmjyIpc=; b=DYWnT3Q4Qs7dhAFfUjL6obNO2q8Hmy6VC93LhnbFG+2VMlRRgpi1+WHwZSBKev+J4r 9+y0PMbSOXkI+225GUOsPrTTiDkvVwvKxPCcGpa7OsZj5caUY/Zb0V1aF8tMzbc004Ls /Mmtdk2Jo4bsJDCSxztpnUIg6a8KE8lLzMwEvZ8J48abQBeN4CIhFlDPe2nExqxk8j1S 36JlSDzV2y0BWHef/dCuBAZR52K5BF3pcKS4aNqXorp3s0nwnkU/SulQcgWQfIOzBN+K 5wuo41PEdi8Cks5NZkynGLBihB6B5eb6voFQzPs+xZEF3URpAuJGjk/iucx24wa26Yj8 T48w== X-Gm-Message-State: AOAM532BZWT4liY9eDycmP2Uck/v9Dk7Yv1bjS9fDvtpD1P6AfhcHkOC c01Ps292U+9jdcJWn40Yh+aRn+pbfZeclKsX X-Received: by 2002:a7b:cbc8:: with SMTP id n8mr7567498wmi.186.1603884560710; Wed, 28 Oct 2020 04:29:20 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id g5sm5698229wmi.4.2020.10.28.04.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 04:29:19 -0700 (PDT) Date: Wed, 28 Oct 2020 12:29:17 +0100 From: Daniel Vetter To: Maxime Ripard Cc: Hoegeun Kwon , eric@anholt.net, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, dave.stevenson@raspberrypi.com, sungguk.na@samsung.com Subject: Re: [PATCH 1/1] drm/vc4: drv: Add error handding for bind Message-ID: <20201028112917.GW401619@phenom.ffwll.local> Mail-Followup-To: Maxime Ripard , Hoegeun Kwon , eric@anholt.net, airlied@linux.ie, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, dave.stevenson@raspberrypi.com, sungguk.na@samsung.com References: <20201027041442.30352-1-hoegeun.kwon@samsung.com> <20201027041442.30352-2-hoegeun.kwon@samsung.com> <20201027145431.zasv2oiydglz3n63@gilmour.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201027145431.zasv2oiydglz3n63@gilmour.lan> X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2020 at 03:54:31PM +0100, Maxime Ripard wrote: > Hi, > > On Tue, Oct 27, 2020 at 01:14:42PM +0900, Hoegeun Kwon wrote: > > There is a problem that if vc4_drm bind fails, a memory leak occurs on > > the drm_property_create side. Add error handding for drm_mode_config. > > > > Signed-off-by: Hoegeun Kwon > > Applied, thanks! Switching over to drmm_ version of this would also be good I think. Together with the devm_ version for allocating the drm_device you could delete a pile of that fragile cleanup code. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch