Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp744756pxx; Wed, 28 Oct 2020 16:16:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyF0Y/cP4zYkyX++oe9K2iISk132/1yXdxQPswWX8CbFBEOokRD8cS4FRJ51TVGikDJkAJQ X-Received: by 2002:aa7:dc50:: with SMTP id g16mr1256188edu.95.1603927001774; Wed, 28 Oct 2020 16:16:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603927001; cv=none; d=google.com; s=arc-20160816; b=DVjIR491GyJyaV5N6pQ3tK2EgdO3VhG57qKrGz7Rp/ML3Q2nyi5mpxZlMUpatg5BX3 KD9Afjm5wmXDz5gjxVxJWnyADstzud1eITk2l7xtHgKxXIFrIeoB72ndh+Vl2FnIveLp iMC9BOtwbed/QAq91+a22L9OsANDhgqQ00a06WBpaS1zn/kIOTLtYggVL5tg5u0Tbn4b AsoVDIvFWLf22fiUdCc48f0d4ng2tvQgu96AXIPlU5Z1nJjMXjJlGvwVcHzIkg2c9SeR W7PRfHlzyH9s6goAINp4H0MMumisM8AG4dxHemOAQ4s3FOHeD5vSrKC5KJsXfMokdcVK lmFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=yQUPqRWZUxbFcHrPhWU6mPxcxxMpSLQVGz+TLjn88eE=; b=01Z1civ3Ies0zJkGZv4Rh2wDwI8bk+R3V84duqKvEN2iwZnN/CRBptS2IyqhL22NtK pZbEi2X7mNT/IDK7uzqkS+nrxgJ48m1t4A7xH9tahRrvGxgwkw3B5ys0wxiwpiK+WH8U PBqp+EqaRyzRNZ2zKZIPTGPdei/B9AGPypSFA/AQk2AfwldTbOAxkcZgf+hAXRmh+9VO PNcgBFfxT2VlhnSGX6ISIKMrBqqjkwB0kNLtUkk34QIRHCwnrcfxw0Wxjpz5mJ0xnMoh C9aUuyQGI7GiYZ126bVWQSZ4pu5B8zekRgiljPmfnZbdjUGiQzF6aUYZnEywY6lWoLP1 Tlkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=T6qHpw87; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id br4si568622ejb.438.2020.10.28.16.16.20; Wed, 28 Oct 2020 16:16:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=T6qHpw87; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390240AbgJ1XOw (ORCPT + 99 others); Wed, 28 Oct 2020 19:14:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:45038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389529AbgJ1XM6 (ORCPT ); Wed, 28 Oct 2020 19:12:58 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1779206FB; Wed, 28 Oct 2020 23:12:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603926778; bh=YtGhFLTEWh3IhMSk1JUw+QTsMFqJxiOvCyFwJrfTBNE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T6qHpw87q6laRew2i8fV7gJ22HUBQEjIxpWzLEyNFuGUNHe9+gTTpjY+gsCekJsTF 9zA1Ue7ZQtBntE7hXpnNoh2TNHusF90/LCdac5PNlKZ4eSRfMgdy7VWhz0NGRRPAF4 KiGqOB3NLeX0z4EdtMNA9t296LxbxLypQs5XLi8c= Date: Wed, 28 Oct 2020 16:12:56 -0700 From: Jakub Kicinski To: Pavana Sharma Cc: f.fainelli@gmail.com, andrew@lunn.ch, davem@davemloft.net, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, vivien.didelot@gmail.com Subject: Re: [PATCH v5 3/3] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell Message-ID: <20201028161256.399bd045@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Oct 2020 10:09:50 +1000 Pavana Sharma wrote: > The Marvell 88E6393X device is a single-chip integration of a 11-port > Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers > and three 10-Gigabit interfaces. >=20 > This patch adds functionalities specific to mv88e6393x family (88E6393X, > 88E6193X and 88E6191X) >=20 > Signed-off-by: Pavana Sharma > --- > Changes in v2: > - Fix a warning (Reported-by: kernel test robot ) > Changes in v3: > - Fix 'unused function' warning > Changes in v4, v5: > - Incorporated feedback from maintainers. drivers/net/dsa/mv88e6xxx/port.c:29:5: warning: no previous prototype for = =E2=80=98mv88e6xxx_port_wait_bit=E2=80=99 [-Wmissing-prototypes] 29 | int mv88e6xxx_port_wait_bit(struct mv88e6xxx_chip *chip, int port, = int reg, | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/dsa/mv88e6xxx/port.c:29:5: warning: symbol 'mv88e6xxx_port_wait= _bit' was not declared. Should it be static? drivers/net/dsa/mv88e6xxx/port.c:29:5: warning: no previous prototype for = =E2=80=98mv88e6xxx_port_wait_bit=E2=80=99 [-Wmissing-prototypes] 29 | int mv88e6xxx_port_wait_bit(struct mv88e6xxx_chip *chip, int port, = int reg, | ^~~~~~~~~~~~~~~~~~~~~~~