Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp42249pxx; Wed, 28 Oct 2020 17:34:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9Kd9VmRDOxlEe0NHzW09QbI1kbDOMmOvWzK7MwtqQ0pwiyosmSmFl9erSEEKK77XcYBYB X-Received: by 2002:a17:906:7f0d:: with SMTP id d13mr1533439ejr.299.1603931677258; Wed, 28 Oct 2020 17:34:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603931677; cv=none; d=google.com; s=arc-20160816; b=nxvBda6Vkl/Er7C3v1jTWa73iCD2G1u9GCYoJzvg/zw8ly2DT5UTxWjp0bu4odgbg+ defevTAhCqz2xQIy5kzGXb3K8yeXvbVn+VDx+MGV0aY8soVS7pJ8t4Hdwgv1Zj5yzyGf bgv4WXQgxE/sCIyjdBXZSkMpSjUVqx2CZ3dPcPGZrYg2CYMKHWCpdPaRQqhupI8RAJrh QCoDFDOHP8K5Cuw/y02LgPEQ1esPU1e8RmY4/7f8XckOcYZBkVLuRb+f27d5C76Q+oQn okZtSJErxlO2fGM2uuVmisJiveWXBJSBJxhey9qSM26AP9itxpVACBN/JpuoNiMh8+Ho 1ADQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=tEVgvYF5WDPLBub1QU+w9c9kPwW/iPLTuSCuPcyzdB8=; b=eWWMjqGRMLuFN49Y+JS9iQs7e0ygGw2d3q6SOJfLunLymCrtrK1VBASujdoFotmMZ5 qoRzMLhXH16W7CBoEvQDGZEJ5Vv2zLRexMqyJrLlirIf9YN1+nWKIZcN7uLNIA5eCx0c 9gsBbi5qczh8JFaeKSvF/2vzOhB+D8IcmzecUwFqMgXtnH6dQJOQMjnIONLMJI+/KKvZ QNnBDrP27Epvq+/TqnymbON2iSNB1Zhum84dfBVLdIWbszxOIjkZpczfaEgW1cMjtSOP NDIVoTO1xRW73PKHmWa5YHc4c20aROPUukbgBtoh02JFigJ1oCwGpDHvpZndexiUIebY MIBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bg3si676534ejb.616.2020.10.28.17.34.15; Wed, 28 Oct 2020 17:34:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730434AbgJ1WH6 (ORCPT + 99 others); Wed, 28 Oct 2020 18:07:58 -0400 Received: from mga11.intel.com ([192.55.52.93]:9420 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730357AbgJ1WHy (ORCPT ); Wed, 28 Oct 2020 18:07:54 -0400 IronPort-SDR: 40FHPcWqQj1zxW/9cQqRsalTkTN8+904YEC5PXmBkLXB00Ob4qcHRmK1QaHzHqiKw7hzTkifXK H3lQQaixz6sQ== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="164795977" X-IronPort-AV: E=Sophos;i="5.77,427,1596524400"; d="scan'208";a="164795977" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 10:04:33 -0700 IronPort-SDR: Wk+cwQAX4UPPu1+Li/FegkOVOmBdRomPZlJPiY7KK86Ir7CYzhZssJFvA7qlf0OpQ6e3vs4Slo YNNYDIsRR5Eg== X-IronPort-AV: E=Sophos;i="5.77,427,1596524400"; d="scan'208";a="351078828" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.160]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 10:04:33 -0700 Date: Wed, 28 Oct 2020 10:04:32 -0700 From: Sean Christopherson To: Arnd Bergmann Cc: Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, Arnd Bergmann , Gleb Natapov , Avi Kivity , Ingo Molnar , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , "H. Peter Anvin" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: kvm: avoid -Wshadow warning in header Message-ID: <20201028170430.GC7584@linux.intel.com> References: <20201026161512.3708919-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201026161512.3708919-1-arnd@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 26, 2020 at 05:14:39PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > There are hundreds of warnings in a W=2 build about a local > variable shadowing the global 'apic' definition: > > arch/x86/kvm/lapic.h:149:65: warning: declaration of 'apic' shadows a global declaration [-Wshadow] > > Avoid this by renaming the local in the kvm/lapic.h header Rather than change KVM, and presumably other files as well, e.g. kvm/lapic.c and apic/io_apic.c also shadow 'apic' all over the place, what about renaming the global 'apic' to something more unique? KVM aside, using such a common name for a global variable has always struck me as a bit odd/dangerous/confusing.