Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Oct 2020 09:54:05 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Sean Christopherson <sean.j.christopherson@intel.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Drop RDPID macro to discourage use of RDPID in the
 kernel
Message-ID: <20201028085405.GW2628@hirez.programming.kicks-ass.net>
References: <20201027214532.1792-1-sean.j.christopherson@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201027214532.1792-1-sean.j.christopherson@intel.com>
Precedence: bulk

On Tue, Oct 27, 2020 at 02:45:32PM -0700, Sean Christopherson wrote:
> Drop the GAS-compatible RDPID macro as RDPID shouldn't be used in the
> kernel, excepting the vDSO, which handcodes RDPID in inline asm.  RDPID
> is unsafe in the kernel because KVM loads guest's TSC_AUX on VM-entry
> and may not restore the host's value until the CPU returns to userspace.
> 
> See commit 6a3ea3e68b8a ("x86/entry/64: Do not use RDPID in paranoid
> entry to accomodate KVM") for details.

Well, remove it because there is no (current) user, OK. But if there's a
compelling kernel side use for it, KVM can go suck rocks.