Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Oct 2020 18:08:26 -0400
From:   Sasha Levin <sashal@kernel.org>
To:     Alan Maguire <alan.maguire@oracle.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH 5.8 574/633] selftests/bpf: Fix overflow tests to reflect
 iter size increase
Message-ID: <20201028220826.GB87646@sasha-vm>
References: <20201027135522.655719020@linuxfoundation.org>
 <20201027135549.734594680@linuxfoundation.org>
 <alpine.LRH.2.21.2010271538290.12876@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <alpine.LRH.2.21.2010271538290.12876@localhost>
Precedence: bulk

On Tue, Oct 27, 2020 at 03:42:10PM +0000, Alan Maguire wrote:
>On Tue, 27 Oct 2020, Greg Kroah-Hartman wrote:
>
>> From: Alan Maguire <alan.maguire@oracle.com>
>>
>> [ Upstream commit eb58bbf2e5c7917aa30bf8818761f26bbeeb2290 ]
>>
>> bpf iter size increase to PAGE_SIZE << 3 means overflow tests assuming
>> page size need to be bumped also.
>>
>
>Alexei can correct me if I've got this wrong but I don't believe
>it's a stable backport candidate.
>
>This selftests change should only be relevant when the BPF iterator
>size has been bumped up as it was in
>
>af65320 bpf: Bump iter seq size to support BTF representation of large
>data structures
>
>...so I don't _think_ this commit belongs in stable unless the
>above commit is backported also (and unless I'm missing something
>I don't see a burning reason to do that currently).
>
>Backporting this alone will likely induce bpf test failures.
>Apologies if the "Fix" in the title was misleading; it should
>probably have been "Update" to reflect the fact it's not fixing
>an existing bug but rather updating the test to operate correctly
>in the context of other changes in the for-next patch series
>it was part of.

I'll drop it, thanks!

-- 
Thanks,
Sasha