Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp56501pxx; Wed, 28 Oct 2020 18:02:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsNWzadeijCIe3dRpCOQF8edec92mXvcZ+yUSiiBVSd5fSO0g2iw3sYujwEJ1CyeFsju6U X-Received: by 2002:a50:e40c:: with SMTP id d12mr1581567edm.35.1603933349655; Wed, 28 Oct 2020 18:02:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603933349; cv=none; d=google.com; s=arc-20160816; b=y565EhnqFF3bmMvY1DaKpXedBpBYamBg6AMHmnUGFUy3dR5dKLb1TGIQPjzNPvasDa 6D8Gs98YRG6bXJPn3Pi+dq4aAEpmXtogXOntv4FrffHiGyLA0fnRqEfzb49XxpGjwmaU p49bdHPpKVP2yzadVdSBmSe1LChEi79W7iGXA+6bcMK61QyfqaWUKxPWT/RS8iWQkg6F vUtjycjFaOMqTjYWDwbgndtM3DZw5oAQAiCviGpSXrPDvl2BDPyEkxjP8REWigIX1OCS r3Hh5HYk560AjTsm5cKGSCo8M2iMUVm0SUGX8L7x68s6ILzBrs/FR9576X7o+cAWnsTp Li2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=PAWofEJM9wv5iPjYaLOdL1gY1jgfQT3VGSBueT4o/DE=; b=q/u+yZyYGZgLCX6WR/I8A2PhtIVKEjZ8KG4h3851iCw0+7wNOSpeQpudmg5zh4t+Ez ttOmQwuE0lKaJojVCTkil7Oc7+zLayb01dLluDScrWh+N/qR/zrbGTJYQjsMiQTNe35L cO7hymwtqKmhz8f7FLkWLVc6oRgWMPGLkwtn1hqO7FPXU7eibFF6jebdG2fHXEXb0/ru CaCtXm1tmElkwcNzrxkzubPafrb0K4JXeQcoqKs149STYBiyaXhoptROhcLgWcQ7bEqW SEQ2rqs9awf8/6k9XxBNGZitdKSn/IHXMazXwDiQchHRhxQGRFC+RIv/D8kY1hAR+3+K x0sA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si991640edn.216.2020.10.28.18.02.07; Wed, 28 Oct 2020 18:02:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731198AbgJ1WON (ORCPT + 99 others); Wed, 28 Oct 2020 18:14:13 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6661 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731162AbgJ1WOB (ORCPT ); Wed, 28 Oct 2020 18:14:01 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CLh5c4Qw1z15NSX; Wed, 28 Oct 2020 16:08:04 +0800 (CST) Received: from linux-lmwb.huawei.com (10.175.103.112) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 16:07:51 +0800 From: Zou Wei To: , CC: , , Zou Wei Subject: [PATCH -next] net: wan: sdla: Use bitwise instead of arithmetic Date: Wed, 28 Oct 2020 16:19:51 +0800 Message-ID: <1603873191-106077-1-git-send-email-zou_wei@huawei.com> X-Mailer: git-send-email 2.6.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.103.112] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccinelle warnings: ./drivers/net/wan/sdla.c:841:38-39: WARNING: sum of probable bitmasks, consider | Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/net/wan/sdla.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wan/sdla.c b/drivers/net/wan/sdla.c index bc2c1c7..cf43f4c 100644 --- a/drivers/net/wan/sdla.c +++ b/drivers/net/wan/sdla.c @@ -838,7 +838,8 @@ static void sdla_receive(struct net_device *dev) case SDLA_S502A: case SDLA_S502E: if (success) - __sdla_read(dev, SDLA_502_RCV_BUF + SDLA_502_DATA_OFS, skb_put(skb,len), len); + __sdla_read(dev, SDLA_502_RCV_BUF | SDLA_502_DATA_OFS, + skb_put(skb, len), len); SDLA_WINDOW(dev, SDLA_502_RCV_BUF); cmd->opp_flag = 0; -- 2.6.2