Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp66482pxx; Wed, 28 Oct 2020 18:22:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjHrxr7bbzh6ymxW+eSkw54Srt0AmZ5Elq6GXvTuLazjgaEGsSJooX2Jprb/C0Y46S5gFm X-Received: by 2002:a17:906:4816:: with SMTP id w22mr1899784ejq.458.1603934557660; Wed, 28 Oct 2020 18:22:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603934557; cv=none; d=google.com; s=arc-20160816; b=S9pjEiOIaMO7ZB/2gXA+wzPUL3cJjAJM7Lg0/zPvqP8pcn9wJarChuNZ2mwkxi5hG1 E2/e4gwMpQ06WmdurjyHUqnFCxwt1LEBzkArjivdPFUbtbW80RlMEGBjU3y6KA6u/JmE y/HuvwOXWvQ4jMYQZZi8plRj9z5ZEO+GSS5jb3bbp7PsMKxDhbbkzqLdw8IScjesrD93 U8/O0IeXhVpkES+T+2o/5YkMyYLANGWpgFf+VTpvECHP71NjUYpnhdVUL2jWOZd1R0K+ swz1oCvQLtmZe3TKky0ebaniMledOyRv71dX5kzoLnNQXVNS1Zf13sR2gnj/7kTWBEMm GI/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uQbbBhHAtYXmoIAeOHrcmMGW25e9SZ+TXIXo2e9EccU=; b=STnktzt04o4SvjoPnPXoiLqP8qI3VIRPUzRTh/0DvVJ2rWg+tMb7oCbYWupqSoOWcb BtAPc0ODF3EhgolkIs1oz+kfkWSpyXLDLNzXCgmGbjd0zmB9vTinubOrSjhm0OQwVw5a liPJDWpv5xo7uY7HS6Cqra6HBG7/6GHbyPffJZM6yQUSObOoEi2/a8Vvhz6wpYhSY970 jvMiNg2Ffxoh/UfPaLAhU7OhK+xNAvUc/0RF+z6M9ECOBahXxOFelAE9LCTBqY7KHiTt pLDz8gj70sAfaqzpp8ZLh/ekVEoDbxtwJ+d5u41OiWojpWcmbBgxWKG6xIJ+pAyjC8Mx 1ivQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d9NrgKXp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l23si926892ejb.488.2020.10.28.18.22.15; Wed, 28 Oct 2020 18:22:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d9NrgKXp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732755AbgJ1WYw (ORCPT + 99 others); Wed, 28 Oct 2020 18:24:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:36834 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732655AbgJ1WWY (ORCPT ); Wed, 28 Oct 2020 18:22:24 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB76224689; Wed, 28 Oct 2020 09:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603876192; bh=U8N6vg6X2eYcSrQSkrm8NKGZN+U0c9/qNL8RW2RKxFY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d9NrgKXpsS6WBfcM7CUhO4Y0J6crO+QvjUheK3Vjd1l/gAs06AMhfllfM1Kra4Ou2 e3w2jfHLO/PybGblgHPD2cu6h4wYzhjh0ZcdQ3VZKrHXG8eOdgwrnyweBLK0r5C/zR 8xxE/m2/ob9Uivgh2Mw2HlS/Q/zDGrh8OMAMpXl0= Date: Wed, 28 Oct 2020 10:10:43 +0100 From: Greg Kroah-Hartman To: Benjamin Berg Cc: linux-usb@vger.kernel.org, Guenter Roeck , linux-kernel@vger.kernel.org, Benjamin Berg , Hans de Goede , Heikki Krogerus Subject: Re: [PATCH 0/2] UCSI race condition resulting in wrong port state Message-ID: <20201028091043.GC1947336@kroah.com> References: <20201009144047.505957-1-benjamin@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201009144047.505957-1-benjamin@sipsolutions.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, 2020 at 04:40:45PM +0200, Benjamin Berg wrote: > From: Benjamin Berg > > Hi all, > > so, I kept running in an issue where the UCSI port information was saying > that power was being delivered (online: 1), while no cable was attached. > > The core of the problem is that there are scenarios where UCSI change > notifications are lost. This happens because querying the changes that > happened is done using the GET_CONNECTOR_STATUS command while clearing the > bitfield happens from the separate ACK command. Any change in between will > be lost. > > Note that the problem may be almost invisible in the UI as e.g. GNOME will > still show the battery as discharging. But some policies like automatic > suspend may be applied incorrectly. > > Cc: Hans de Goede > Cc: Heikki Krogerus > > Benjamin Berg (2): > usb: typec: ucsi: acpi: Always decode connector change information > usb: typec: ucsi: Work around PPM losing change information Do these need to be backported to stable kernel releases? If so, how far back? thjanks, greg k-h