Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750785AbWHPA6j (ORCPT ); Tue, 15 Aug 2006 20:58:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750755AbWHPA6j (ORCPT ); Tue, 15 Aug 2006 20:58:39 -0400 Received: from ozlabs.org ([203.10.76.45]:14529 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S1750738AbWHPA6i (ORCPT ); Tue, 15 Aug 2006 20:58:38 -0400 Subject: RE: [PATCH 4/6] ehea: header files From: Michael Ellerman Reply-To: michael@ellerman.id.au To: Christoph Raisch Cc: "Jenkins, Clive" , linux-kernel , linux-ppc , Marcus Eder , netdev , ossthema@de.ibm.com, Thomas Q Klein In-Reply-To: References: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-C70jxZ6nTIR1cf7UISPn" Date: Wed, 16 Aug 2006 10:58:35 +1000 Message-Id: <1155689915.26911.12.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1801 Lines: 62 --=-C70jxZ6nTIR1cf7UISPn Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2006-08-15 at 13:07 +0200, Christoph Raisch wrote: >=20 > "Jenkins, Clive" wrote on 15.08.2006 12:53:05: >=20 > > > > You mean the eHEA has its own concept of page size? Separate from > > the > > > > page size used by the MMU? > > > > > > > > > > yes, the eHEA currently supports only 4K pages for queues > > > > In that case, I suggest use the kernel's page size, but add a > > compile-time > > check, and quit with an error message if driver does not support it. >=20 > eHEA does support other page sizes than 4k, but the HW interface expects = to > see 4k pages > The adaption is done in the device driver, therefore we have a seperate 4= k > define. Fair enough. You seem to only use it in drivers/net/ehea/ehea_qmr.c, if so put the definition in there, that way someone is less likely to use the EHEA_PAGESIZE definition where they really need PAGE_SIZE. cheers --=20 Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person --=-C70jxZ6nTIR1cf7UISPn Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) iD8DBQBE4m27dSjSd0sB4dIRAjJoAKCYSuXQcxeK2D8QexOog2psXm/5AACdF9fl k8KV682WSg2uHhJ8396+34o= =23RL -----END PGP SIGNATURE----- --=-C70jxZ6nTIR1cf7UISPn-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/