Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] RFC: net: phy: of phys probe/reset issue
To:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>
CC:     "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Sekhar Nori <nsekhar@ti.com>, <linux-kernel@vger.kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Roger Quadros <rogerq@ti.com>,
        Russell King <linux@armlinux.org.uk>,
        Rob Herring <robh+dt@kernel.org>
References: <20201023174750.21356-1-grygorii.strashko@ti.com>
 <450d262e-242c-77f1-9f06-e25943cc595c@gmail.com>
 <20201023201046.GB752111@lunn.ch>
From:   Grygorii Strashko <grygorii.strashko@ti.com>
Message-ID: <87f264f7-da24-61db-2339-59a88d88e533@ti.com>
Date:   Wed, 28 Oct 2020 21:32:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201023201046.GB752111@lunn.ch>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

hi Andrew,

On 23/10/2020 23:10, Andrew Lunn wrote:
>> Yes there is: have your Ethernet PHY compatible string be of the form
>> "ethernetAAAA.BBBB" and then there is no need for such hacking.
>> of_get_phy_id() will parse that compatible and that will trigger
>> of_mdiobus_register_phy() to take the phy_device_create() path.
> 
> Yep. That does seem like the cleanest way to do this. Let the PHY
> driver deal with the resources it needs.

Thanks you for your comments.

huh. I gave it try and some thinking. it works as W/A, but what does it mean in the long term?

Neither Linux documentation, neither DT bindings suggest such solution in any way
(and there is *Zero* users of ""ethernet-phy-id%4x.%4x" in the current LKML).
And the main reason for this RFC is really bad customer experience while migrating to the new kernels, as
mdio reset does not support multi-phys and phy resets are not working.

Following your comments, my understanding for the long term (to avoid user's confusions) is:
"for OF case the usage of 'ethernet-phy-id%4x.%4x' compatibly is became mandatory for PHYs
to avoid PHY resets dependencies from board design and bootloader".

Which in turn means - update all reference boards by adding ""ethernet-phy-id%4x.%4x" and add
new DT board files for boards which are differ by only PHY version.

:(

-- 
Best regards,
grygorii