Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp249422pxx; Thu, 29 Oct 2020 01:25:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJCIKD3kcwsCWNKaJwpN9Wq0jLC1w8n/4eTAguWbvQhi0pSgAQMyvuIP0YW4HbfN1071cw X-Received: by 2002:a17:907:70cb:: with SMTP id yk11mr2958674ejb.122.1603959942824; Thu, 29 Oct 2020 01:25:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603959942; cv=none; d=google.com; s=arc-20160816; b=HUe6K5qpU7DiSDRuNW3Tw1OxiKIGuQBXWX2S5lYa1R5G/fSI/5OoH68RWdRc+C+PNB xG29fa3EtCo+oDzDsxgRKVLnR+p3ZYjDt3bxYmcubT83osMAaaz0lOJ110vAqVsqOHJd j3dmCwAzXaZ9RirZT7sNFvQxrR3HMkmvEGQMqtPqJjLxhvvJPeroK7xJY+50OoMbt5L3 LLLQXncKD3Sxm8fnf2Y9POIw4fVmI+XwDHBp92glusPc3jCYraTh4xQMPSR89xT8FcVd wG4g+uAW71CJsUkyaRbexDn8RiB/XzByIZqS2GmK/kIRhwe45ai1FFWM8C9mSZcNdMHw GvHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7jNAEm6Hi0csIlAhJak64h6CkXzGG/PjJ55O7rc69w0=; b=y48o85hhdpRrIvvcYP4Uftr6NqzFgVEKtmoihASu/0i3ncIur2YOzwv3Sr4hBxrQPy Qm1OWcZQmAsEoRygbZeZY8JaYW9C1DiDhS4ZIUPs6MGGp3D/OgZHltikHQGQAkgL3vTb Q0SqWo9yXyDdT3RWYuZCJoiwUv+J83fgidB4KLHMKrf8ENZ/d0p12mUfJo+Xs52DuH6A jsUn4IFEzXGsGH7Bwl8IfQfyvq6+1jCTIfjx6DUc5XMmurjwmDxOQMlIOJ7j94QJ/zko +uMCDUUfhewGIajL9iMdtx4Ka9ZNUera3qv6ZdJMMrx5LxoO/8QWyEPVOpGD7UYBm/5U azkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=dVbiFvDr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs1si1850155edb.116.2020.10.29.01.25.20; Thu, 29 Oct 2020 01:25:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=dVbiFvDr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388385AbgJ2A34 (ORCPT + 99 others); Wed, 28 Oct 2020 20:29:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728106AbgJ2A3p (ORCPT ); Wed, 28 Oct 2020 20:29:45 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6821FC0613CF for ; Wed, 28 Oct 2020 17:29:45 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id r127so1064868lff.12 for ; Wed, 28 Oct 2020 17:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7jNAEm6Hi0csIlAhJak64h6CkXzGG/PjJ55O7rc69w0=; b=dVbiFvDr5hJzG53SMPD8precPJBr4LhbfNdzfOWJKKosCPkE3U8Ech812UHrucQHfv E6ottCjFlpuwTsu3cvPVUcLBNhLxknUL9qAC1EQEH5lFYv0YOqmeBBkai/fZm68Y1uGJ OHmPM76qoxHM+OiAeFY4lENZ6ebZWLhWm47PA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7jNAEm6Hi0csIlAhJak64h6CkXzGG/PjJ55O7rc69w0=; b=ueRXNG1NcgCetwu6jOstSlIf2VIPjAHDd7KAwTkQ7O2+JH/O5qt/4e0VJWGq4PCsHQ TRwh2qqK3MmKQpEXpa0lFQMFh/oWWUw8EXY4ic6sOnztn8aPHew9YTzxFqwNRxpW5pXu gJq/lPVQ6FK9PDk9rlXy06+JAEEmPhJcbcw5peI/esh1SMCQ3OJOCE5xPxMUyA3XoILS SUjcmAjScmQT41VZq/ttB8xSvDeX1gb59BaTxGhtGzoXNMHC2O/mmVGFaw+oGptBmUqi 2ANseQFY/LaKf/NQB9XEYcaAxE4bYDfg37axMrFLOLuBkeyr9nqRtGdy1jcycfWAIy4X BvDA== X-Gm-Message-State: AOAM530ye5nuRO0ydz6n4co81sa0bMhVMkkN4EQOI08SfUMMaLdaoJqB D1FFyFysPmW9YBc4Fesm2BvB80KHOnV1DQ== X-Received: by 2002:ac2:4244:: with SMTP id m4mr539980lfl.562.1603931383703; Wed, 28 Oct 2020 17:29:43 -0700 (PDT) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id m13sm105466lfl.269.2020.10.28.17.29.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Oct 2020 17:29:43 -0700 (PDT) Received: by mail-lf1-f41.google.com with SMTP id v6so1056302lfa.13 for ; Wed, 28 Oct 2020 17:29:42 -0700 (PDT) X-Received: by 2002:a19:6b0d:: with SMTP id d13mr519613lfa.485.1603931382411; Wed, 28 Oct 2020 17:29:42 -0700 (PDT) MIME-Version: 1.0 References: <20201016192654.32610-1-evgreen@chromium.org> <20201016122559.v2.1.I8b447ca96abfbef5f298d77350e6c9d1d18d00f6@changeid> In-Reply-To: From: Evan Green Date: Wed, 28 Oct 2020 17:29:05 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/4] dt-bindings: nvmem: Add soc qfprom compatible strings To: Doug Anderson Cc: Rob Herring , Bjorn Andersson , Srinivas Kandagatla , Stephen Boyd , Andy Gross , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 21, 2020 at 2:41 PM Doug Anderson wrote: > > Hi, > > On Fri, Oct 16, 2020 at 12:27 PM Evan Green wrote: > > > > Add SoC-specific compatible strings so that data can be attached > > to it in the driver. > > > > Signed-off-by: Evan Green > > --- > > > > Changes in v2: > > - Add other soc compatible strings (Doug) > > - Fix compatible string definition (Doug) > > > > .../devicetree/bindings/nvmem/qcom,qfprom.yaml | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > > index 1a18b6bab35e7..eb1440045aff1 100644 > > --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > > +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > > @@ -14,7 +14,18 @@ allOf: > > > > properties: > > compatible: > > - const: qcom,qfprom > > + items: > > + - enum: > > + - qcom,apq8064-qfprom > > + - qcom,apq8084-qfprom > > + - qcom,msm8974-qfprom > > + - qcom,msm8916-qfprom > > + - qcom,msm8996-qfprom > > + - qcom,msm8998-qfprom > > + - qcom,qcs404-qfprom > > + - qcom,sc7180-qfprom > > + - qcom,sdm845-qfprom > > + - const: qcom,qfprom > > > > reg: > > # If the QFPROM is read-only OS image then only the corrected region > > As Rob's bot found, your example no longer matches your requirements. > It needs an SoC-specific string plus the "qcom,qfprom". It's always > good to try running "make dt_binding_check" to catch these sorts of > things. Thanks Doug, will do for the next spin! -Evan