Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp258778pxx; Thu, 29 Oct 2020 01:45:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweMmAmd+F2GvWIpxv8WEnT/A2QghvOQgj9ans79Q686xcsqWUGqTI+PgT3ITKzRavMEG77 X-Received: by 2002:a17:906:32d7:: with SMTP id k23mr2968429ejk.294.1603961112773; Thu, 29 Oct 2020 01:45:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603961112; cv=none; d=google.com; s=arc-20160816; b=vpaSbfl4qA+UcqkkHusBtOWBzMAqjWHvTX0RKvZZpxgPp2YB3q4SWPYirYXp7ZCtBn MGFbZnXLoYBFXwuHpMkxZLqcILwWdlLUTCveBs/Krd9n5KWB3FG3VpJcqVOAUwxIYpWh 3TyAj1tidHUxu7/9GstLTtqcVND5ZJHgjnCu1SPKsgGN7nLcxShXMrm0mMD0zYCbYw9W kH4bzWBRg8lAadtN55e5N71kPxu1bYCBYDky/p1KaOEQrH6Z92m2GzUhh/USPBpHPwLA 7I82o/FLjI00/EF5vUfbO8Nu8hFXaNgKx+zF6+j2ahHYLjiuYoB3zGQSc4tieMUiM+Dr vi6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=w951fwgn35XWQrlUJC6YzZUT/WtvBa3kfTEOfWgRzOc=; b=p0yOPUFX+jxqDEltZYKWvZSCbA4x8vPfZbmY34iuXQCpOpgnqFSMeABdFFG2rce1EJ Mflp7tH9EudzF/zhpYUC133gvmomuX890Fy2XvO6kGNkjoXcHR32PmF026m4XrHgEDiq Vo9gJWcs/NySfDkyooMOluJQcDq16C/re7ThCagMJNGO3Gg9zcWH++DS2NIWqqBHLUwC sGepcDXPBNl+PAQjAPWSVYeFbpg2BZ3izRn3iWV+epzsqhrmVzr746Geo45Oqdnbdq+t vgDfKoNVjHrFA1zDJrd4TPSv+GPOp3kQrVKQiJyHfKuQfQMlpcvgu7YB6mmuIYWY/j+E VxCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w3si1335371ejo.13.2020.10.29.01.44.51; Thu, 29 Oct 2020 01:45:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730738AbgJ2BB5 (ORCPT + 99 others); Wed, 28 Oct 2020 21:01:57 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:6569 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731502AbgJ1WRW (ORCPT ); Wed, 28 Oct 2020 18:17:22 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CLfXp16fvzhcmf; Wed, 28 Oct 2020 14:58:02 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 28 Oct 2020 14:57:56 +0800 Subject: Re: [f2fs-dev] [PATCH 1/1] f2fs-toos:fsck.f2fs Fix bad return value To: Robin Hsu , , , CC: References: <20201026094000.1500425-1-robinhsu@google.com> From: Chao Yu Message-ID: <299c9027-e137-83ff-b2ba-8af07144a488@huawei.com> Date: Wed, 28 Oct 2020 14:57:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201026094000.1500425-1-robinhsu@google.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/10/26 17:40, Robin Hsu via Linux-f2fs-devel wrote: > 'ret' should not have been used here: otherwise, it would be wrongly used > as the error code and then be returned from main(). > > Signed-off-by: Robin Hsu BTW, how about changing 'ret = EXIT_ERR_CODE' to 'ret = FSCK_ERRORS_LEFT_UNCORRECTED', it's not critical though. Reviewed-by: Chao Yu Thanks,