Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] firmware/dmi: Include product_sku info to modalias
To:     Jean Delvare <jdelvare@suse.de>
Cc:     linux-kernel@vger.kernel.org
References: <20201028035015.8897-1-kaichuan.hsieh@canonical.com>
 <20201028100455.28cad0f5@endymion>
From:   Kai-Chuan Hsieh <kaichuan.hsieh@canonical.com>
Message-ID: <c165ab45-dbcc-8d7a-10ad-a66d6a157fbe@canonical.com>
Date:   Wed, 28 Oct 2020 17:15:00 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201028100455.28cad0f5@endymion>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Jean,

Thanks for your reminder, I'll read the document for future submission.
Sorry for not following the rule this time.

Thanks,
KaiChuan

On 10/28/20 5:04 PM, Jean Delvare wrote:
> Hi Kai-Chuan,
> 
> On Wed, 28 Oct 2020 11:50:15 +0800, Kai-Chuan Hsieh wrote:
>> Some Dell platforms rely on modalias to customize configuration,
>> the product sku can be more specific for the hardware.
>>
>> Add product_sku to modalias for better utilization.
>>
>> Signed-off-by: Kai-Chuan Hsieh <kaichuan.hsieh@canonical.com>
>> ---
>>   drivers/firmware/dmi-id.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/firmware/dmi-id.c b/drivers/firmware/dmi-id.c
>> index 86d71b0212b1..4d5421d14a41 100644
>> --- a/drivers/firmware/dmi-id.c
>> +++ b/drivers/firmware/dmi-id.c
>> @@ -85,6 +85,7 @@ static ssize_t get_modalias(char *buffer, size_t buffer_size)
>>   		{ "svn", DMI_SYS_VENDOR },
>>   		{ "pn",  DMI_PRODUCT_NAME },
>>   		{ "pvr", DMI_PRODUCT_VERSION },
>> +		{ "sku", DMI_PRODUCT_SKU },
>>   		{ "rvn", DMI_BOARD_VENDOR },
>>   		{ "rn",  DMI_BOARD_NAME },
>>   		{ "rvr", DMI_BOARD_VERSION },
> 
> Applied, thanks.
> 
> For your future submissions, I invite you to read
> Documentation/process/submitting-patches.rst
> 
> Specifically, when submitting a new version of a patch, please:
> * Replace [PATCH] with [PATCH v2] in the subject.
> * Do not reply to the previous version of the patch, instead start a
>    new thread.
> * Ideally, include a list of changes from previous version, between the
>    "---" marker and the diffstat.
> 
> Thanks,
>